stabilize packages features #35742
Closed
stabilize packages features #35742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested: |
GeoffreyBooth
reviewed
Oct 21, 2020
doc/api/packages.md
Outdated
|
|
||
| When a package has an [`"exports"`][] field, this will take precedence over the | ||
| `"main"` field when importing the package by name. | ||
|
|
There was a problem hiding this comment.
I think @guybedford deliberately wanted this below "exports" because we want people to be preferring "exports" over "main".
There was a problem hiding this comment.
the ordering is changed in #35741
I can update it there
There was a problem hiding this comment.
I'm not tied to the ordering, it just a suggestion previously since there was no explicit ordering (it not being alphabetical).
There was a problem hiding this comment.
Maybe the list on L825 can have its ordering stated ("In order of precedence, the possible entries are:") while the headers can be in alphabetical order?
4 tasks
This comment has been minimized.
This comment has been minimized.
guybedford
approved these changes
Oct 21, 2020
ryzokuken
approved these changes
Oct 22, 2020
|
This probably shouldn't land before the runtime deprecation in #35747 because otherwise that runtime deprecation is semver-major? |
Trott
reviewed
Oct 22, 2020
|
@Trott the folder pathing stuff is currently no longer documented and unaffected by this change |
These features are being used in production and are ready to be considered stable. Refs: nodejs/modules#564
MylesBorins
force-pushed
the
mark-features-stable
branch
from
fdfbd1d
to
c9a55e3
Compare
fhinkel
approved these changes
Oct 26, 2020
jasnell
approved these changes
Oct 26, 2020
GeoffreyBooth
approved these changes
Oct 26, 2020
|
@nodejs/modules I would like to land this. If there are no objections within 24 hours I will land it tomorrow. @Trott I removed your blocked label as I don't believe the feature you pointed out is affected by this change. Please let me know if you think I'm mistaken |
Trott
approved these changes
Oct 26, 2020
|
Landed in acdfc16 |
MylesBorins
added a commit
that referenced
this issue
Oct 29, 2020
These features are being used in production and are ready to be considered stable. Refs: nodejs/modules#564 PR-URL: #35742 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this issue
Nov 3, 2020
These features are being used in production and are ready to be considered stable. Refs: nodejs/modules#564 PR-URL: #35742 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
3 tasks
DerekNonGeneric
added
the
dont-land-on-v14.x
MylesBorins
added
baking-for-lts
BethGriggs
pushed a commit
that referenced
this issue
Dec 8, 2020
These features are being used in production and are ready to be considered stable. Refs: nodejs/modules#564 PR-URL: #35742 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this issue
Apr 29, 2021
These features are being used in production and are ready to be considered stable. Refs: nodejs/modules#564 PR-URL: #35742 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
These features are being used in production and are ready to be
considered stable.
Refs: nodejs/modules#564
Depends on #35741
/cc @nodejs/modules