X Tutup
The Wayback Machine - https://web.archive.org/web/20220423172410/https://github.com/nodejs/node/pull/34460
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: guard against nullptr deref in TimerWrapHandle::Stop #34460

Closed
wants to merge 1 commit into from
Closed

src: guard against nullptr deref in TimerWrapHandle::Stop #34460

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jul 21, 2020

Refs: #34454

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ timers labels Jul 21, 2020
@addaleax addaleax mentioned this pull request Jul 21, 2020
Closed
4 tasks
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jul 21, 2020 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/32442/ (💚)

@jasnell jasnell added the author ready label Jul 21, 2020
@jasnell
Copy link
Member

@jasnell jasnell commented Jul 21, 2020

Fast-track? Please 👍🏻

@addaleax addaleax added the fast-track label Jul 21, 2020
@addaleax
Copy link
Member Author

@addaleax addaleax commented Jul 21, 2020

Landed in feb93c4

@addaleax addaleax closed this Jul 21, 2020
addaleax added a commit that referenced this issue Jul 21, 2020
@addaleax
src: guard against nullptr deref in TimerWrapHandle::Stop
feb93c4 
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@addaleax addaleax deleted the timer-wrap-nullptr-deref branch Jul 21, 2020
cjihrig pushed a commit that referenced this issue Jul 23, 2020
@addaleax @cjihrig
src: guard against nullptr deref in TimerWrapHandle::Stop
fe69e1e 
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@ruyadorno ruyadorno added the backport-requested-v14.x label Jul 28, 2020
@ruyadorno
Copy link
Member

@ruyadorno ruyadorno commented Jul 28, 2020

This does not land cleanly on v14.x 🤔 should it be backported ?

@targos targos removed author ready backport-requested-v14.x labels Apr 30, 2021
targos pushed a commit that referenced this issue May 1, 2021
@addaleax @targos
src: guard against nullptr deref in TimerWrapHandle::Stop
b1d5160 
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@gengjiawen gengjiawen

@devnexen devnexen

@richardlau richardlau

Assignees
No one assigned
Labels
c++ fast-track timers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@addaleax @nodejs-github-bot @jasnell @ruyadorno @gengjiawen @devnexen @richardlau @targos
X Tutup