X Tutup
The Wayback Machine - https://web.archive.org/web/20230220192736/https://github.com/nodejs/node/commit/bd38dfbfcc
Skip to content
Permalink
Browse files
domain: add name to monkey-patched emit function
The domain module monkey patches EventEmitter.prototype.emit(),
however the function's name was becoming the empty string. This
commit forces the new emit function to have the proper name.

PR-URL: #37550
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
cjihrig authored and targos committed May 1, 2021
1 parent 13d972d commit bd38dfb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
@@ -456,7 +456,7 @@ EventEmitter.init = function() {
};

const eventEmit = EventEmitter.prototype.emit;
EventEmitter.prototype.emit = function(...args) {
EventEmitter.prototype.emit = function emit(...args) {
const domain = this.domain;

const type = args[0];
@@ -9,7 +9,7 @@ const inspector = require('inspector');

process.on('warning', common.mustCall((warning) => {
assert.strictEqual(warning.code, 'DEP0097');
assert.match(warning.message, /Triggered by calling <anonymous> on process/);
assert.match(warning.message, /Triggered by calling emit on process/);
}));

domain.create().run(() => {

0 comments on commit bd38dfb

Please sign in to comment.
X Tutup