domain: show falsy names as anonymous for DEP0097

Many anonymous functions use the empty string as their name. Since the DEP0097 logic was using nullish coalescing, these functions were not being displayed as anonymous. This commit updates the logic to use || instead of ??. PR-URL: #37550 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · May 1, 2021 · 13d972d · 13d972d
1 parent 0255ed7
commit 13d972d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/domain.js b/lib/domain.js
@@ -130,7 +130,7 @@ function emitMakeCallbackDeprecation({ target, method }) {
       'Using a domain property in MakeCallback is deprecated. Use the ' +
       'async_context variant of MakeCallback or the AsyncResource class ' +
       'instead. ' +
-      `(Triggered by calling ${method?.name ?? '<anonymous>'} ` +
+      `(Triggered by calling ${method?.name || '<anonymous>'} ` +
       `on ${target?.constructor?.name}.)`,
       'DeprecationWarning', 'DEP0097');
     sendMakeCallbackDeprecation = true;

diff --git a/test/parallel/test-domain-dep0097.js b/test/parallel/test-domain-dep0097.js
@@ -0,0 +1,17 @@
+'use strict';
+const common = require('../common');
+
+common.skipIfInspectorDisabled();
+
+const assert = require('assert');
+const domain = require('domain');
+const inspector = require('inspector');
+
+process.on('warning', common.mustCall((warning) => {
+  assert.strictEqual(warning.code, 'DEP0097');
+  assert.match(warning.message, /Triggered by calling <anonymous> on process/);
+}));
+
+domain.create().run(() => {
+  inspector.open();
+});