Rework marshal.rs to use an error enum #4125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
coolreader18
commented
Aug 23, 2022
coolreader18
commented
- Rework frozenset construction
- Rework marshal.rs to use an error enum
youknowone
reviewed
Aug 23, 2022
| use num_traits::Zero; | ||
| use std::str; | ||
|
|
||
| #[derive(num_enum::TryFromPrimitive)] |
| inner: PySetInner, | ||
| } | ||
|
|
||
| impl PyFrozenSetBuilder<'_> { |
Member
There was a problem hiding this comment.
This type looks like to be able to be used for both frozenset and set.
Then instead of build and build_with_type, PyFrozenSet::from_builder PyFrozenSet::from_builder_with_type, and From<PyFrozenSetBuilder> for PySet will cover any possible use case
Comment on lines
+299
to
+300
| let sign = if len < 0 { Sign::Minus } else { Sign::Plus }; | ||
| let len = len.unsigned_abs() as usize; |
Member
There was a problem hiding this comment.
Not a big deal but this is changed from single comparison to double comparison (symentically)
Suggested change
| let sign = if len < 0 { Sign::Minus } else { Sign::Plus }; | |
| let len = len.unsigned_abs() as usize; | |
| let (sign, len) = if len < 0 { | |
| (Sign::Minus, (-len) as usize) | |
| } else { | |
| (Sign::Plus, len as usize) | |
| }; |
Contributor
There was a problem hiding this comment.
I actually prefer what @coolreader18 wrote here because its intention is clearer. However, I do have one improvement for the first line:
Suggested change
| let sign = if len < 0 { Sign::Minus } else { Sign::Plus }; | |
| let len = len.unsigned_abs() as usize; | |
| let sign = if len.is_negative() { Sign::Minus } else { Sign::Plus }; | |
| let len = len.unsigned_abs() as usize; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.