Swift: extract some more Expr
#11190
Open
+400
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-scanning[bot]](https://web.archive.org/web/20221109225142im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** | ||
| * `#fileLiteral`, `#imageLiteral` and `#colorLiteral` expressions, which are used in playgrounds. | ||
| */ |
Check warning
Code scanning / CodeQL
Class QLDoc style.
MathiasVP
reviewed
Nov 9, 2022
| class ObjectLiteralExpr extends Synth::TObjectLiteralExpr, LiteralExpr { | ||
| override string getAPrimaryQlClass() { result = "ObjectLiteralExpr" } | ||
|
|
||
| /** | ||
| * Gets the |
There was a problem hiding this comment.
hmm . all alone at the end is weird
MathiasVP
reviewed
Nov 9, 2022
| * An ambiguous expression that might refer to multiple declarations. This will be present only | ||
| * for failing compilations. |
There was a problem hiding this comment.
Out of curiosity: Will it ever then actually be in a real database?
There was a problem hiding this comment.
I think not, not unless:
- there's an actual failure in the compilation, or
- there's a bug in our extractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.