New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the assert and use a relatively larger capacity to cover possible increase of .NET ref assemblies #17423
Conversation
src/Microsoft.PowerShell.Commands.Utility/commands/utility/AddType.cs
Outdated
Show resolved
Hide resolved
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
Thank you both for the review! |
|
Handy links: |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment


PR Summary
Fix #17384
Update the code that gets the default reference assemblies in
Add-Typeto remove the assert and use a more deterministic way to get the needed capacity.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.