X Tutup
The Wayback Machine - https://web.archive.org/web/20220418203644/https://github.com/PowerShell/PowerShell/pull/16437
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest notice file #16437

Merged
merged 1 commit into from Apr 1, 2022
Merged

Update to the latest notice file #16437

merged 1 commit into from Apr 1, 2022

Conversation

Copy link
Contributor

@github-actions github-actions bot commented Nov 10, 2021

Automated changes by create-pull-request GitHub action

Copy link
Member

@TravisEz13 TravisEz13 left a comment

rejecting as tool detected 52 updated components as not public.

PR should update it self in time.

@msftbot msftbot bot added the Waiting on Author label Nov 10, 2021
@daxian-dbw daxian-dbw assigned TravisEz13 and unassigned daxian-dbw Nov 10, 2021
@github-actions github-actions bot requested a review from TravisEz13 Nov 11, 2021
@msftbot msftbot bot removed the Waiting on Author label Nov 11, 2021
@github-actions github-actions bot force-pushed the update-cgmanifest branch 4 times, most recently from 4100bda to e8dea32 Compare Nov 16, 2021
@github-actions github-actions bot force-pushed the update-cgmanifest branch 3 times, most recently from 4a38f60 to d34d1f3 Compare Nov 24, 2021
@github-actions github-actions bot force-pushed the update-cgmanifest branch 4 times, most recently from ce2e6c0 to eea1ce6 Compare Dec 7, 2021
@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Dec 7, 2021

I followed up with OSS Engineering about why the notice isn't generating correctly.

@github-actions github-actions bot force-pushed the update-cgmanifest branch 5 times, most recently from b73b054 to 10b1e0a Compare Dec 15, 2021
@github-actions github-actions bot force-pushed the update-cgmanifest branch 3 times, most recently from 68a0204 to a471b37 Compare Dec 18, 2021
@github-actions github-actions bot force-pushed the update-cgmanifest branch 4 times, most recently from 0a3e558 to c8142f0 Compare Feb 11, 2022
@github-actions github-actions bot force-pushed the update-cgmanifest branch 4 times, most recently from d4846a6 to d21be61 Compare Feb 23, 2022
@github-actions github-actions bot force-pushed the update-cgmanifest branch 3 times, most recently from c01f4f2 to e1921ba Compare Mar 1, 2022
@github-actions github-actions bot force-pushed the update-cgmanifest branch 2 times, most recently from e7fab7f to a2ff843 Compare Mar 5, 2022
@github-actions github-actions bot force-pushed the update-cgmanifest branch 2 times, most recently from bb95c58 to dad8b54 Compare Mar 17, 2022
@github-actions github-actions bot force-pushed the update-cgmanifest branch 5 times, most recently from d4dfab9 to f135311 Compare Mar 25, 2022
@github-actions github-actions bot force-pushed the update-cgmanifest branch 3 times, most recently from ce41313 to cada604 Compare Mar 31, 2022
@pull-request-quantifier
Copy link

@pull-request-quantifier pull-request-quantifier bot commented Apr 1, 2022

This PR has 479 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +405 -74
Percentile : 82.63%

Total files changed: 1

Change summary by file extension:
.txt : +405 -74

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 merged commit be99881 into master Apr 1, 2022
43 checks passed
@TravisEz13 TravisEz13 deleted the update-cgmanifest branch Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants
X Tutup