X Tutup
The Wayback Machine - https://web.archive.org/web/20221024173031/https://github.com/python/cpython/pull/98571
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96746: Make Py_TPFLAGS_DISALLOW_INSTANTIATION flag non-inheritable #98571

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-96746: Make Py_TPFLAGS_DISALLOW_INSTANTIATION flag non-inheritable #98571

wants to merge 7 commits into from
+92 −7

Conversation

chgnrdv
Copy link
Contributor

@chgnrdv chgnrdv commented Oct 23, 2022 •
edited by bedevere-bot

chgnrdv added 6 commits Oct 21, 2022
@chgnrdv
Prevent inheritance of Py_TPFLAGS_DISALLOW_INSTANTIATION flag set on …
8e99390 
…parent type

If Py_TPFLAGS_BASETYPE and Py_TPFLAGS_DISALLOW_INSTANTIATION flags are set on type defined in extension module, child type, if not setting Py_TPFLAGS_DISALLOW_INSTANTIATION flag itself, should be instantiable
@chgnrdv
Changed object_new to PyType_GenericNew
e2b3bbc
@chgnrdv
Refactor
eafb3fe
@chgnrdv
Added tests
6ab8015
@chgnrdv
Finished adding tests
a81cf4a
@chgnrdv
Fixed comments
ace1ea3
@chgnrdv chgnrdv changed the title Make Py_TPFLAGS_DISALLOW_INSTANTIATION flag non-inheritable gh-96746: Make Py_TPFLAGS_DISALLOW_INSTANTIATION flag non-inheritable Oct 23, 2022
@chgnrdv chgnrdv marked this pull request as ready for review Oct 23, 2022
@chgnrdv chgnrdv requested a review from markshannon as a code owner Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subtypes of extension type inherit Py_TPFLAGS_DISALLOW_INSTANTIATION flag
2 participants
@chgnrdv @bedevere-bot
X Tutup