Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPester v5 #1444
Merged
Pester v5 #1444
Conversation
added 30 commits
Apr 12, 2020
…leanup tests
…some -Skip problems already
…1 to fix indentation
|
@rjmholt @JamesWTruher Pester v5 has released today after multiple RC iterations. It's much cleaner but a tad slower, especially on PowerShell 5.1, which hasn't back-ported the speculative execution perf fix PowerShell/PowerShell#10269 |
|
Part way through the review, will continue later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedApr 17, 2020
•
edited
PR Summary
Migration to use new Pester v5.
It has cleaner scoping and test setup has to go into a
BeforeAllblock, except for things that need to be evaluated at discovery time (therefore test cases also had to be inlined), see https://github.com/pester/Pester/blob/v5.0/README.mdSome cleanup had to be done as part of it. PSScriptAnalyzer is now only imported once before running tests (import is needed as some tests reference the PSSA types). Some tests were also cleaned up to not depend on
PSScriptAnalyzerTestHelper.psm1any more. I also started adding the Copyright header to the test files. The speed of test execution is roughly the same as v4.A diff that ignores indentation/whitespace will make the review much easier
I suggest we wait for the GA of v5 but the PR is already ready.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.