New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type inference error for empty return statements #18351
Fix type inference error for empty return statements #18351
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh heck yeah @MartinGC94! I was about to investigate this today, as I found in writing this regression test: PowerShell/PowerShellEditorServices#1935 it was indeed a PowerShell bug, and only affecting Core. Thing is, in Windows PowerShell the script that user gave us is returning these completion results:
Actual: [[Variable] false, [Variable] $, [Variable] ?, [Variable] ^, [Variable] ast, ...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for catching this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!


PR Summary
Fixes the type inference for empty return statements so this:
$var = return;$var.<Tab>no longer throws an error.PR Context
This was causing the following issue: PowerShell/PowerShellEditorServices#1926
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).