X Tutup
The Wayback Machine - https://web.archive.org/web/20221228043619/https://github.com/PowerShell/PowerShell/pull/14319
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GetDirectories in CimDscParser #14319

Merged
merged 4 commits into from Dec 13, 2022

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 4, 2020

Avoid array allocations from GetDirectories/GetFiles.

Contributes to #14318.

@daxian-dbw daxian-dbw requested a review from anmenaga Dec 4, 2020
@daxian-dbw daxian-dbw assigned anmenaga and unassigned TravisEz13 Dec 4, 2020
@msftbot msftbot bot added the Review - Needed The PR is being reviewed label Dec 12, 2020
@msftbot
Copy link

msftbot bot commented Dec 12, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze xtqqczze changed the title Replace GetFiles in CimDscParser Avoid array allocations from GetDirectories/GetFiles in CimDscParser Apr 6, 2021
@xtqqczze xtqqczze changed the title Avoid array allocations from GetDirectories/GetFiles in CimDscParser Replace GetDirectories in CimDscParser Apr 6, 2021
@xtqqczze xtqqczze closed this Apr 6, 2021
@xtqqczze xtqqczze reopened this Apr 6, 2021
@xtqqczze xtqqczze closed this Jun 25, 2021
@xtqqczze xtqqczze reopened this Jun 25, 2021
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 27, 2021
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jun 27, 2021

CodeFactor issues are false positives.

@xtqqczze xtqqczze closed this Aug 24, 2021
@xtqqczze xtqqczze reopened this Aug 24, 2021
@anmenaga anmenaga closed this Nov 30, 2021
@anmenaga anmenaga reopened this Nov 30, 2021
@msftbot msftbot bot removed the Review - Needed The PR is being reviewed label Nov 30, 2021
@msftbot msftbot bot added the Review - Needed The PR is being reviewed label Dec 8, 2021
@msftbot
Copy link

msftbot bot commented Dec 8, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13 TravisEz13 added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Aug 30, 2022
@msftbot msftbot bot added the Stale label Sep 14, 2022
@msftbot
Copy link

msftbot bot commented Sep 14, 2022

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@msftbot msftbot bot removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Sep 15, 2022
@xtqqczze xtqqczze force-pushed the GetFiles-CimDscParser branch 2 times, most recently from 35ed26f to dd038a9 Compare Sep 15, 2022
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Sep 15, 2022

rebased to resolve CodeFactor issues

@iSazonov
Copy link
Collaborator

iSazonov commented Sep 15, 2022

2 years - time to merge 😄

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Sep 21, 2022

PowerShell-CI-linux failure seems unrelated:

Invoke-WebRequest tests.Denial of service.Charset Parsing

Expected the actual value to be greater than 5, but got 4.98730809053562.

@iSazonov iSazonov requested a review from SteveL-MSFT Sep 22, 2022
@msftbot msftbot bot added the Review - Needed The PR is being reviewed label Sep 29, 2022
@msftbot
Copy link

msftbot bot commented Sep 29, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 17, 2022

@SteveL-MSFT Can you please re-review.

@iSazonov iSazonov closed this Dec 13, 2022
@msftbot msftbot bot removed the Review - Needed The PR is being reviewed label Dec 13, 2022
@iSazonov iSazonov reopened this Dec 13, 2022
@iSazonov
Copy link
Collaborator

iSazonov commented Dec 13, 2022

/rebase

@pull-request-quantifier
Copy link

pull-request-quantifier bot commented Dec 13, 2022

This PR has 11 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +5 -6
Percentile : 4.4%

Total files changed: 1

Change summary by file extension:
.cs : +5 -6

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Dec 13, 2022
@iSazonov iSazonov merged commit 4ff581e into PowerShell:master Dec 13, 2022
36 checks passed
@msftbot
Copy link

msftbot bot commented Dec 20, 2022

🎉v7.4.0-preview.1 has been released which incorporates this pull request.🎉

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants
X Tutup