X Tutup
The Wayback Machine - https://web.archive.org/web/20220611063342/https://github.com/PowerShell/PowerShell/pull/16760
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more efficient platform detection API #16760

Merged
merged 2 commits into from Jan 27, 2022

Conversation

iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Jan 17, 2022

PR Summary

Use static and const new OperatingSystem class API to avoid string comparisons and extra allocations.

PR Context

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup label Jan 17, 2022
@iSazonov iSazonov force-pushed the cleanup-operatingsystem-api branch from 381ad8e to b97efea Compare Jan 17, 2022
@msftbot msftbot bot added Waiting on Author and removed Waiting on Author labels Jan 18, 2022
Copy link
Collaborator

@PaulHigin PaulHigin left a comment

LGTM

iSazonov added 2 commits Jan 19, 2022
Use static and const new OperatingSystem class API to avoid string comparisons and extra allocations.
@iSazonov iSazonov force-pushed the cleanup-operatingsystem-api branch from 6231fab to 2df0e80 Compare Jan 19, 2022
@pull-request-quantifier
Copy link

@pull-request-quantifier pull-request-quantifier bot commented Jan 19, 2022

This PR has 31 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +15 -16
Percentile : 12.4%

Total files changed: 9

Change summary by file extension:
.cs : +15 -16

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@msftbot msftbot bot added the Review - Needed label Jan 26, 2022
@msftbot
Copy link

@msftbot msftbot bot commented Jan 26, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Copy link
Member

@daxian-dbw daxian-dbw left a comment

LGTM

@PaulHigin
Copy link
Collaborator

@PaulHigin PaulHigin commented Jan 26, 2022

@iSazonov Can you please fill out the PR checklist above?

@msftbot msftbot bot removed the Review - Needed label Jan 26, 2022
@iSazonov
Copy link
Collaborator Author

@iSazonov iSazonov commented Jan 27, 2022

@PaulHigin Done.

@PaulHigin PaulHigin merged commit 9f722ef into PowerShell:master Jan 27, 2022
45 checks passed
@iSazonov iSazonov deleted the cleanup-operatingsystem-api branch Jan 27, 2022
@msftbot
Copy link

@msftbot msftbot bot commented Feb 24, 2022

🎉v7.3.0-preview.2 has been released which incorporates this pull request.🎉

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup