X Tutup
The Wayback Machine - https://web.archive.org/web/20220924131351/https://github.com/nodejs/node/pull/44769
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: add validateBuffer to improve error #44769

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fs: add validateBuffer to improve error #44769

wants to merge 2 commits into from
+2 −1

Conversation

wafuwafu13
Copy link
Contributor

@wafuwafu13 wafuwafu13 commented Sep 24, 2022

when params is { buffer: null }, buffer is not initialized with Buffer.alloc(16384). so error message became not user-friendly as seen in test case.

node/lib/fs.js

Line 621 in abfeed8

({ buffer = Buffer.alloc(16384) } = params ?? kEmptyObject);

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 24, 2022
aduh95
aduh95 reviewed Sep 24, 2022
View changes
test/parallel/test-fs-read.js Outdated
{
name: 'TypeError',
message: 'The "buffer" argument must be an instance of Buffer, ' +
'TypedArray, or DataView. Received null',
},
Copy link
Contributor

@aduh95 aduh95 Sep 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not validate the message, but rather the error code.

Suggested change
{
name: 'TypeError',
message: 'The "buffer" argument must be an instance of Buffer, ' +
'TypedArray, or DataView. Received null',
},
{ code: 'ERR_INVALID_ARG_TYPE' },

Copy link
Contributor Author

@wafuwafu13 wafuwafu13 Sep 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fixed b7ba2c3

@aduh95
Copy link
Contributor

aduh95 commented Sep 24, 2022

/cc @nodejs/fs

@aduh95 aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 24, 2022
@wafuwafu13 wafuwafu13 mentioned this pull request Sep 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wafuwafu13 @aduh95 @nodejs-github-bot
X Tutup