X Tutup
The Wayback Machine - https://web.archive.org/web/20221017170541/https://github.com/git/git/pull/1333
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode: update the width tables to Unicode 15 #1333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fcharlie
Copy link
Contributor

@fcharlie fcharlie commented Sep 17, 2022

Unicode 15 Released[0] and including several additional zero/double width characters.

[0] https://home.unicode.org/announcing-the-unicode-standard-version-15-0/

unicode-width.h regenerated by contrib/update-unicode/update_unicode.sh

@gitgitgadget-git
Copy link

gitgitgadget-git bot commented Sep 17, 2022

There are issues in commit 7d13ed3:
unicode: update the width tables to Unicode 15
Lines in the body of the commit messages should be wrapped between 60 and 76 characters.
Indented lines, and lines without whitespace, are exempt

@fcharlie
Copy link
Contributor Author

fcharlie commented Sep 17, 2022

/submit

@gitgitgadget-git
Copy link

gitgitgadget-git bot commented Sep 17, 2022

Submitted as pull.1333.git.git.1663388320380.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-1333/fcharlie/update-unicode-15-v1

To fetch this version to local tag pr-git-1333/fcharlie/update-unicode-15-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-1333/fcharlie/update-unicode-15-v1

@gitgitgadget-git
Copy link

gitgitgadget-git bot commented Sep 19, 2022

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Force Charlie via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Force Charlie <charlieio@outlook.com>
>
> Unicode 15 Released[0] and including several additional zero/double
> width characters.
>
> [0] https://home.unicode.org/announcing-the-unicode-standard-version-15-0/
>
> Signed-off-by: Force Charlie <charlieio@outlook.com>
> ---
>     unicode: update the width tables to Unicode 15
>     
>     Unicode 15 Released[0] and including several additional zero/double
>     width characters.
>     
>     [0]
>     https://home.unicode.org/announcing-the-unicode-standard-version-15-0/

Thanks.

Where are you getting the information to update these ranges from,
among 4489 new characters?  Is there a readily accessible URL that
is more suitable than the announcement of the whole collection?

@fcharlie
Copy link
Contributor Author

fcharlie commented Sep 19, 2022

In fact, I re-run contrib/update-unicode/update_unicode.sh,
which downloads the latest Unicode data and then generates
a new unicode-width.h. The process can be retried.

@fcharlie
Copy link
Contributor Author

fcharlie commented Sep 19, 2022

/submit

@gitgitgadget-git
Copy link

gitgitgadget-git bot commented Sep 19, 2022

Error: 02d214d was already submitted

@gitgitgadget-git
Copy link

gitgitgadget-git bot commented Sep 19, 2022

On the Git mailing list, Junio C Hamano wrote (reply to this):

Junio C Hamano <gitster@pobox.com> writes:

> "Force Charlie via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Force Charlie <charlieio@outlook.com>
>>
>> Unicode 15 Released[0] and including several additional zero/double
>> width characters.
>>
>> [0] https://home.unicode.org/announcing-the-unicode-standard-version-15-0/
>>
>> Signed-off-by: Force Charlie <charlieio@outlook.com>
>> ---
> Thanks.
>
> Where are you getting the information to update these ranges from,
> among 4489 new characters?  Is there a readily accessible URL that
> is more suitable than the announcement of the whole collection?

Ah, it would probably is a good idea to say what you did to prepare
this patch in this case, like:

    Unicode 15 that was released recentry [0] includes several
    additional zero/double width characters.

    Update unicode-width.h table by cd'ing to contrib/update-unicode/
    and running update_unicode.sh script there.

    [0] https://home.unicode.org/announcing-the-unicode-standard-version-15-0/

or something, I guess.

Thanks.

Unicode 15 Released[0] and including several additional zero/double
width characters.

[0] https://home.unicode.org/announcing-the-unicode-standard-version-15-0/

unicode-width.h regenerated by contrib/update-unicode/update_unicode.sh

Signed-off-by: Force Charlie <charlieio@outlook.com>
@fcharlie
Copy link
Contributor Author

fcharlie commented Sep 19, 2022

/submit

@gitgitgadget-git
Copy link

gitgitgadget-git bot commented Sep 19, 2022

Submitted as pull.1333.v2.git.git.1663614033063.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-1333/fcharlie/update-unicode-15-v2

To fetch this version to local tag pr-git-1333/fcharlie/update-unicode-15-v2:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-1333/fcharlie/update-unicode-15-v2

@fcharlie
Copy link
Contributor Author

fcharlie commented Sep 19, 2022

/submit

@gitgitgadget-git
Copy link

gitgitgadget-git bot commented Sep 19, 2022

Error: 462fc64 was already submitted

@dscho
Copy link
Member

dscho commented Sep 22, 2022

In fact, I re-run contrib/update-unicode/update_unicode.sh, which downloads the latest Unicode data and then generates a new unicode-width.h. The process can be retried.

@fcharlie please reply on the list, as instructed in https://github.com/gitgitgadget/gitgitgadget/wiki/ReplyToThis

@fcharlie
Copy link
Contributor Author

fcharlie commented Sep 22, 2022

In fact, I re-run contrib/update-unicode/update_unicode.sh, which downloads the latest Unicode data and then generates a new unicode-width.h. The process can be retried.

@fcharlie please reply on the list, as instructed in https://github.com/gitgitgadget/gitgitgadget/wiki/ReplyToThis

Both my Outlook email and qq email were blocked, and I ended up using icloud email to reply to this

my reply:
https://lore.kernel.org/git/A502C1AE-CD49-46FB-B5ED-0513BABF7AD1@icloud.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants
X Tutup