X Tutup
The Wayback Machine - https://web.archive.org/web/20221027041022/https://github.com/python/cpython/pull/98151
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #98151

Closed
wants to merge 1 commit into from
Closed

Update __init__.py #98151

wants to merge 1 commit into from

Conversation

Nemo2011
Copy link

@Nemo2011 Nemo2011 commented Oct 10, 2022

@Nemo2011 Nemo2011 requested a review from a team as a code owner Oct 10, 2022
@bedevere-bot
Copy link

bedevere-bot commented Oct 10, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@sobolevn
Copy link
Member

sobolevn commented Oct 10, 2022

Please, don't do this :)
Right now this looks like a spam.

There are actual work pieces in issue tracker, solving which can benefit to everyone :)

@sobolevn sobolevn closed this Oct 10, 2022
@sobolevn
Copy link
Member

sobolevn commented Oct 11, 2022

I am sorry, this is not a spam.

@Nemo2011 please, next time describe the problem / solution better :)

This PR removes a garbled character. Reopening.

@sobolevn sobolevn reopened this Oct 11, 2022
@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 11, 2022

(Cc. @carljm as well, since this PR is a successor to #98122.)

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 11, 2022

For the benefit of other reviewers: this PR removes a U+000c character that is present on line 28 of Lib/email/__init__.py. This unicode character is "invisible", so the change doesn't show up on the GitHub diff, making it look like this is an "empty" PR. However, if you open Lib/email/__init__.py (as it exists on the main branch) in VSCode or IDLE, you can see the character:

image

Interestingly enough, it looks like the character has been in the source code for around 15 years now, since 8b3febe.

@gvanrossum
Copy link
Member

gvanrossum commented Oct 11, 2022

I am rejecting this PR. It is not well motivated and the Python source code has long contained ^L characters, strategically placed to allow certain Emacs users to jump to them as "page" level separators. ^L is treated as a newline in the Python lexer.

@gvanrossum gvanrossum closed this Oct 11, 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants
X Tutup