X Tutup
The Wayback Machine - https://web.archive.org/web/20221012025656/https://github.com/python/cpython/pull/98130
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

venv commands #98130

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

venv commands #98130

wants to merge 3 commits into from

Conversation

musvaage
Copy link

@musvaage musvaage commented Oct 9, 2022

fix prompts for POSIX shells

replaced bash/zsh with Bourne compatible (Almquist shell also works with the command)

replaced source with its shortcut . where available

third commit reverts my change using . instead of source for fish

evidently the fish documentation authors don't know the history of bash; where source wasn't an "alias"

". (a single period) is an alias for the source command. The use of . is deprecated in favour of source, and
. will be removed in a future version of fish."

@musvaage musvaage requested a review from vsajip as a code owner Oct 9, 2022
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Oct 9, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

bedevere-bot commented Oct 9, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@musvaage
Copy link
Author

musvaage commented Oct 9, 2022

possibly these lines might be edited

avoid ambiguity regarding csh/tcsh

  .. versionadded:: 3.4
-    ``fish`` and ``csh`` activation scripts.
+    ``.fish`` and ``.csh`` activation scripts.

don't use plural

  .. versionadded:: 3.8
-    PowerShell activation scripts installed under POSIX for PowerShell Core
+    PowerShell activation script installed under POSIX for PowerShell Core
     support.

or, more concise

  .. versionadded:: 3.8
-    PowerShell activation scripts installed under POSIX for PowerShell Core
-    support.
+    ``.ps1`` activation script for PowerShell Core.

@vsajip vsajip added the pending The issue will be closed if no feedback is provided label Oct 10, 2022
Copy link
Member

@vsajip vsajip left a comment

I don't see that these changes add anything especially useful - they just seem to be slightly different ways of saying the same thing, but too slight to warrant changing.

@musvaage
Copy link
Author

musvaage commented Oct 10, 2022

useful

the table has a $ prompt for all POSIX platform shells listed

zsh factually has the prompt as host%

Bash Reference Manual / 4.1 Bourne Shell Builtins

. (a period)

perhaps bash's inclusion of source as an alternative to its Bourne Shell Builtin . was taken from the C shell

were one to draft a book on programming, the table in its current form would not meet the approval of a proofreader

@bedevere-bot
Copy link

bedevere-bot commented Oct 10, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

bedevere-bot commented Oct 10, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review pending The issue will be closed if no feedback is provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup