X Tutup
The Wayback Machine - https://web.archive.org/web/20220612141234/https://github.com/python/devguide/issues/834
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on how to verify/sign commits on GitHub #834

Open
Mariatta opened this issue Apr 14, 2022 · 2 comments
Open

Add info on how to verify/sign commits on GitHub #834

Mariatta opened this issue Apr 14, 2022 · 2 comments
Labels

Comments

@Mariatta
Copy link
Sponsor Member

@Mariatta Mariatta commented Apr 14, 2022

GitHub documentation about verified commits: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

We should advise contributors to sign and verify their commits. This way, we can be sure that they actually own the email address they use in their commits.

@gpshead
Copy link
Member

@gpshead gpshead commented Apr 14, 2022

That's a false promise. GPG does not verify identity or email addresses. It merely verifies access to a private key. Logging into GitHub effectively does the same thing.

For a signature to do more than that people would have to become GPG zealots with key signing chains of trust and a pinky swear never store their GPG privates credentials on the same machine that ever has their GitHub credentials or equivalents. I can probably count people who meet that criteria in Python land on one hand.

Signed commits within git may be useful in some git circumstances, and aren't harmful, but they run the risk of people believing that signature means something it cannot without a level of OpSec we can't require of committers, let alone contributors. It seems like a more interesting concept for actually distributed projects rather than things centralizing on GitHub.

So if we're going to mention this in the docs just merely link to the GitHub info on it as something people might want to do. Let's not make any authentication claims about it.

Apologies for standing on a 🧼 🎁. 😋

@Mariatta
Copy link
Sponsor Member Author

@Mariatta Mariatta commented Apr 14, 2022

Thanks for the correction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
X Tutup