X Tutup
The Wayback Machine - https://web.archive.org/web/20221223142912/https://github.com/python/cpython/pull/96543
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-88355: Fix backslashes in AF_PIPE #96543

Merged
merged 1 commit into from Oct 4, 2022

Conversation

cousteaulecommandant
Copy link
Contributor

@cousteaulecommandant cousteaulecommandant commented Sep 3, 2022

The correct syntax for AF_PIPE addresses is \\.\pipe\blahblah, not \.\pipe{blahblah}, but the syntax markup messed up the backslashes.

The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes.
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Sep 3, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Yup, this looks to be the right fix. LGTM, thanks 👍

@orsenthil
Copy link
Member

orsenthil commented Oct 4, 2022

Copy link
Member

@orsenthil orsenthil left a comment

LGTM

@orsenthil orsenthil merged commit ff28d89 into python:main Oct 4, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 4, 2022

Thanks @cousteaulecommandant for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 4, 2022

GH-97854 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

bedevere-bot commented Oct 4, 2022

GH-97855 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2022
Fix backslashes in AF_PIPE (pythonGH-88355)

The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes.
(cherry picked from commit ff28d89)

Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2022
Fix backslashes in AF_PIPE (pythonGH-88355)

The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes.
(cherry picked from commit ff28d89)

Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>
orsenthil pushed a commit that referenced this pull request Oct 4, 2022
gh-88355: Fix backslashes in AF_PIPE (GH-96543)

Fix backslashes in AF_PIPE (GH-88355)

The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes.
(cherry picked from commit ff28d89)

Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>

Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>
orsenthil pushed a commit that referenced this pull request Oct 4, 2022
gh-88355: Fix backslashes in AF_PIPE (GH-96543)

Fix backslashes in AF_PIPE (GH-88355)

The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes.
(cherry picked from commit ff28d89)

Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>

Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
Fix backslashes in AF_PIPE (python#88355)

The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes.
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
gh-88355: Fix backslashes in AF_PIPE (GH-96543)

Fix backslashes in AF_PIPE (GH-88355)

The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes.
(cherry picked from commit ff28d89)

Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>

Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants
X Tutup