X Tutup
The Wayback Machine - https://web.archive.org/web/20221223140611/https://github.com/python/cpython/pull/32376
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47243: Duplicate entry in 'Objects/unicodetype_db.h' #32376

Merged
merged 4 commits into from Sep 28, 2022
Merged

bpo-47243: Duplicate entry in 'Objects/unicodetype_db.h' #32376

merged 4 commits into from Sep 28, 2022

Conversation

LiarPrincess
Copy link
Contributor

@LiarPrincess LiarPrincess commented Apr 6, 2022 •
edited by miss-islington

Fix for duplicate 1st entry in 'Objects/unicodetype_db.h':

/* a list of unique character type descriptors */
const _PyUnicode_TypeRecord _PyUnicode_TypeRecords[] = {
    {0, 0, 0, 0, 0, 0},
    {0, 0, 0, 0, 0, 0}, <--- HERE
    {0, 0, 0, 0, 0, 32},
    {0, 0, 0, 0, 0, 48},
    …

https://bugs.python.org/issue47243

https://bugs.python.org/issue47243

Automerge-Triggered-By: GH:isidentical

@the-knights-who-say-ni

This comment was marked as outdated.

Sign in to view
@LiarPrincess
Copy link
Contributor Author

LiarPrincess commented Apr 6, 2022

CLA is signed, but there is this 'at least one business day before our records are updated'.

@ambv ambv removed the CLA signed label Apr 15, 2022
@ambv ambv closed this Apr 15, 2022
@ambv ambv reopened this Apr 15, 2022
@bedevere-bot
Copy link

bedevere-bot commented Apr 15, 2022

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@LiarPrincess
Copy link
Contributor Author

LiarPrincess commented Apr 16, 2022

NEWS entry added.

Issue after migration #91399.

@kumaraditya303 kumaraditya303 requested a review from isidentical Sep 13, 2022
@cfbolz
Copy link
Contributor

cfbolz commented Sep 19, 2022

FWIW, this change looks correct to me (the original problem was a small miss-thought, I think).

@isidentical
Copy link
Sponsor Member

isidentical commented Sep 19, 2022

@LiarPrincess can you regenerate the unicodedata (and then I think we can merge it in). Thanks @cfbolz for the review!

@isidentical isidentical added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Sep 28, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Sep 28, 2022

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 0c1d7a0 into python:main Sep 28, 2022
14 checks passed
@isidentical
Copy link
Sponsor Member

isidentical commented Sep 28, 2022

Thanks for the PR @LiarPrincess!

@LiarPrincess
Copy link
Contributor Author

LiarPrincess commented Sep 28, 2022

Thanks for review.
Updated with main & regenerated 'unicodetype_db.h' with Unicode 15.0.

@LiarPrincess LiarPrincess deleted the Duplicate-entry-in-Objects-unicodetype_db.h branch Sep 28, 2022
@LiarPrincess LiarPrincess mannequin mentioned this pull request Oct 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidentical isidentical

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@LiarPrincess @the-knights-who-say-ni @bedevere-bot @cfbolz @isidentical @miss-islington @ambv @kumaraditya303
X Tutup