X Tutup
The Wayback Machine - https://web.archive.org/web/20220321113003/https://github.com/angular/angular/pull/41526
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zone.js): update several flaky cases #41526

Closed
wants to merge 1 commit into from

Conversation

JiaLiPassion
Copy link
Contributor

@JiaLiPassion JiaLiPassion commented Apr 8, 2021

Related to #41434

Fix several flaky cases.

  1. should restore window.onerror in test cases.
  2. expect().toThrow() should pass a function.

@JiaLiPassion JiaLiPassion requested a review from alan-agius4 Apr 8, 2021
@google-cla google-cla bot added the cla: yes label Apr 8, 2021
@ngbot ngbot bot added this to the Backlog milestone Apr 8, 2021
@JiaLiPassion JiaLiPassion marked this pull request as draft Apr 9, 2021
Related to angular#41434

Fix several flaky cases.

1. should restore `window.onerror` in test cases.
2. expect().toThrow() should pass a function.
@JiaLiPassion JiaLiPassion marked this pull request as ready for review Dec 18, 2021
@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Jan 24, 2022

This PR was merged into the repository by commit 25a83eb.

@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Feb 24, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
X Tutup