Return correct FileName property for Get-Item when listing alternate data streams #18019

kilasuit · 2022-09-03T08:00:38Z

PR Summary

PR Context

PR Checklist

dkaszews

If you change "Fixes issue #18018" to "Fixes #18018" in description, it should link properly with "In-PR" tag and autoclose on merge; now it's just a mention.

iSazonov · 2022-09-03T18:12:37Z

test/powershell/Modules/Microsoft.PowerShell.Management/Get-Item.Tests.ps1

@@ -28,10 +28,10 @@ Describe "Get-Item" -Tags "CI" {
    }

    It "Using -literalpath should find no additional files" {
-        $null = New-Item -type file "$TESTDRIVE/file[abc].txt"
-        $null = New-Item -type file "$TESTDRIVE/filea.txt"
+        $null = New-Item -type file "$TESTDRIVE\file[abc].txt"


I wonder how is this related to the PR? Please undo all unrelated changes.

@iSazonov if you look at the commit message where this was made it is to clean up a discrepancy in the tests that was uncovered when a prior test failed. So no I won't undo this commit

You would have saved reviewers time if you had added a link to the post you are talking about.

The error occurs only in the new test you added. This fact indicates that only the following lines should be corrected because these tests are only Windows test:

$altStreamPath = "$TESTDRIVE\altStream.txt" $altStreamDirectory = "$TESTDRIVE\altstreamdir" $noAltStreamDirectory = "$TESTDRIVE\noaltstreamdir"

Changes in other tests should be reverted because they are not related to this PR.

@iSazonov I can waste time in issuing an additional PR correcting this error across other test files or I can save time by including it within this PR seeing as it it related to the PR. If you don't agree with me that's fine, but this change in my opinion makes sense.

Have you analyzed all the code paths? What if this is done intentionally? You are forcing every reviewer to spend time analyzing the history of these tests even though they have nothing to do with this PR.

If you really think that these tests contain a bug, then make a new PR to improve them.

By making irrelevant changes you waste both your time and the time of code reviewers.

@kilasuit I agree with @iSazonov here. I appreciate you trying to fix issues to the tests, but if they are unrelated to the PR, it makes it confusing why they are being changed and implies the PR caused some problem that requires this change. PowerShell is expected to normalize the slashes, so I don't understand why this change is necessary at all unless there's a problem in PowerShell handling the slashes.

My suggestion is to revert the unrelated test changes and create a new PR referencing the issue being addressed to provide more context to the reviewers why the change needs to be made. Thanks!

@SteveL-MSFT based on your comments, I've undone the commit that changed the rest of the tests and force pushed my branch with only the changes that I found were required for the tests to pass in this PR to be able to be merged.

iSazonov · 2022-09-07T06:20:13Z

test/powershell/Modules/Microsoft.PowerShell.Management/Get-Item.Tests.ps1

@@ -28,10 +28,10 @@ Describe "Get-Item" -Tags "CI" {
    }

    It "Using -literalpath should find no additional files" {
-        $null = New-Item -type file "$TESTDRIVE/file[abc].txt"
-        $null = New-Item -type file "$TESTDRIVE/filea.txt"
+        $null = New-Item -type file "$TESTDRIVE\file[abc].txt"


Have you analyzed all the code paths? What if this is done intentionally? You are forcing every reviewer to spend time analyzing the history of these tests even though they have nothing to do with this PR.

If you really think that these tests contain a bug, then make a new PR to improve them.

By making irrelevant changes you waste both your time and the time of code reviewers.

pull-request-quantifier · 2022-09-20T21:08:52Z

This PR has 8 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +5 -3
Percentile : 3.2%

Total files changed: 2

Change summary by file extension:
.cs : +1 -2
.ps1 : +4 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 👌 👎 (Email)
Customize PullRequestQuantifier for this repository.

msftbot · 2022-09-28T02:01:17Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

kilasuit added 3 commits Sep 3, 2022

Fix PowerShell#18018

df84af7

Add Test

e9a0a94

spelling mistake

cdc20e9

kilasuit requested a review from anmenaga as a code owner Sep 3, 2022

pull-request-quantifier bot added the Extra Small label Sep 3, 2022

msftbot bot assigned TravisEz13 Sep 3, 2022

Fix failing test

1924431

dkaszews approved these changes Sep 3, 2022

View changes

iSazonov reviewed Sep 3, 2022

View changes

iSazonov requested changes Sep 7, 2022

View changes

msftbot bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 7, 2022

kilasuit force-pushed the 18018 branch from 491f2c8 to 1924431 Compare Sep 20, 2022

msftbot bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 20, 2022

msftbot bot added the Review - Needed The PR is being reviewed label Sep 28, 2022

Oct	NOV	Dec
	28
2021	2022	2023

Return correct FileName property for Get-Item when listing alternate data streams #18019

Return correct FileName property for Get-Item when listing alternate data streams #18019

kilasuit commented Sep 3, 2022 •

edited

dkaszews left a comment

iSazonov Sep 3, 2022

kilasuit Sep 3, 2022

iSazonov Sep 5, 2022

kilasuit Sep 6, 2022

iSazonov Sep 7, 2022

SteveL-MSFT Sep 19, 2022

kilasuit Sep 20, 2022

iSazonov Sep 7, 2022

pull-request-quantifier bot commented Sep 20, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

msftbot bot commented Sep 28, 2022

Return correct FileName property for Get-Item when listing alternate data streams #18019

Are you sure you want to change the base?

Return correct FileName property for Get-Item when listing alternate data streams #18019

Conversation

kilasuit commented Sep 3, 2022 • edited

PR Summary

PR Context

PR Checklist

dkaszews left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pull-request-quantifier bot commented Sep 20, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

msftbot bot commented Sep 28, 2022

kilasuit commented Sep 3, 2022 •

edited