X Tutup
The Wayback Machine - https://web.archive.org/web/20230407082621/https://github.com/PowerShell/PowerShell/pull/17680
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Devcontainer updates and support codespaces #17680

Closed
wants to merge 12 commits into from
Closed

WIP: Devcontainer updates and support codespaces #17680

wants to merge 12 commits into from
+123 −73

Conversation

JustinGrote
Copy link
Contributor

@JustinGrote JustinGrote commented Jul 14, 2022 •
edited

PR Summary

This provides several updates with the goal of enabling a PowerShell contributor to begin contributing as fast as possible to PowerShell utilizing a devcontainer or CodeSpaces and Visual Studio Code.

  • Update devcontainer base OS to official vscode Ubuntu 18.04 devcontainer image
  • Add devcontainer tooling and initial setup scripts to match the docs/building/linux.md document as closely as possible
  • Add setup steps mirrored from the codespaces devcontainer repo to ensure proper codespaces support
  • Remove legacy Fedora references that are no longer reference in the codebase or Azure Pipelines AFAIK

Known Issues

  • Codespaces doesnt support WaitFor on the creation commands yet, so occasionally a race condition occurs where omnisharp loads before dotnet has been bootstrapped by Start-PSBootstrap, leading to a dotnet not found message. This can be resolved by just reloading the window. I can also suppress the message but I chose not to as it seems to be fairly rare. Once waitfor is supported then this won't be an issue

PR Context

PR Checklist

@JustinGrote JustinGrote mentioned this pull request Jul 14, 2022
Open
@msftbot msftbot bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 20, 2022
@msftbot msftbot bot added the Stale label Aug 4, 2022
@msftbot
Copy link

msftbot bot commented Aug 4, 2022

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@JustinGrote
Copy link
Contributor Author

@msftbot still active, just life stuff in between :)

@msftbot msftbot bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Aug 4, 2022
@fflaten
Copy link
Contributor

fflaten commented Aug 17, 2022

Maybe include <EnableWindowsTargeting>true</EnableWindowsTargeting> per project or in a Directory.Build.props in the root so we can compile for Windows. Had to use that to catch all errors in #17769.

@JustinGrote
Copy link
Contributor Author

@fflaten I don't think windows containers are supported for either devcontainers or codespaces?

@msftbot msftbot bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 19, 2022
@fflaten
Copy link
Contributor

fflaten commented Aug 19, 2022 •
edited by unfurl-links bot

@fflaten I don't think windows containers are supported for either devcontainers or codespaces?

Not Windows containers, but being able to run Start-PSBuild -Runtime win7-x64 in Ubuntu container. Without that property it won't download the required Windows targeting packs. See https://docs.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1100

Learn about the .NET SDK error message that instructs you to set the EnableWindowsTargeting property to true.

@msftbot msftbot bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 23, 2022
@msftbot msftbot bot added the Stale label Sep 7, 2022
@msftbot
Copy link

msftbot bot commented Sep 7, 2022

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@JustinGrote
Copy link
Contributor Author

Thanks @msftbot, still active :)

@msftbot msftbot bot closed this Sep 17, 2022
@pull-request-quantifier
Copy link

This PR has 154 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Medium
Size       : +97 -57
Percentile : 50.8%

Total files changed: 13

Change summary by file extension:
.json : +73 -25
.ps1 : +22 -3
.gitignore : +2 -1
.devcontainer/Dockerfile : +0 -20
.devcontainer/fedora30/Dockerfile : +0 -8

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@msftbot msftbot bot removed the Stale label Sep 18, 2022
@msftbot msftbot bot added the Stale label Oct 3, 2022
@msftbot
Copy link

msftbot bot commented Oct 3, 2022

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@JustinGrote
Copy link
Contributor Author

@SeeminglyScience I'm going to let this go dormant but I do plan to still finish it, when I do I'll ask you to reopen it.

@JustinGrote JustinGrote closed this Oct 5, 2022
@msftbot msftbot bot removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Oct 5, 2022
@JustinGrote
Copy link
Contributor Author

@SteveL-MSFT have some time to investigate this again. Question: Prebuilds now use Github Actions, and are stored in Github storage. These have a free allocation now for public repos, as such will this be possible to do now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw

@TravisEz13 TravisEz13

@adityapatwardhan adityapatwardhan

@anmenaga anmenaga

@PaulHigin PaulHigin

Assignees

@anmenaga anmenaga

Labels
Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JustinGrote @fflaten @anmenaga @SeeminglyScience
X Tutup