X Tutup
The Wayback Machine - https://web.archive.org/web/20221223181258/https://github.com/python/cpython/pull/96986
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking 鈥淪ign up for GitHub鈥, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enum] Remove unused code from test_enum.py #96986

Merged
merged 1 commit into from Dec 7, 2022
Merged

[Enum] Remove unused code from test_enum.py #96986

merged 1 commit into from Dec 7, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 21, 2022

While reading #96475 I found that there are some unused definitions on test_enum.py that should be removed.

I am not going to open an issue about that, because it is a test-only minor detail 馃憤

@sobolevn sobolevn requested a review from ethanfurman as a code owner Sep 21, 2022
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 21, 2022
ethanfurman
ethanfurman reviewed Sep 21, 2022
View changes
Copy link
Member

@ethanfurman ethanfurman left a comment

I need to look more closely at the two _dir entries and make sure they shouldn't be used.

@sobolevn
Copy link
Member Author

sobolevn commented Sep 21, 2022

They might be. I was in doubt about them. But these lines look like they do something very similar: https://github.com/python/cpython/pull/96986/files#diff-8467f9fbbff81abf26d87a8dbbf0e0c866157971948010e48cc73539251a9e4cL4519-L4525

@ethanfurman ethanfurman merged commit 889b0b9 into python:main Dec 7, 2022
12 checks passed
@ethanfurman ethanfurman self-assigned this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman

Assignees

@ethanfurman ethanfurman

Labels
3.12 skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sobolevn @ethanfurman @bedevere-bot
X Tutup