New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable broken macOS CI job, which is unused #17221
Conversation
Disable broken macOS CI job, which is unused
|
@anmenaga, @TravisEz13, the macOS daily build has been successful, for quite some time. Is the change in this PR really need to be ported to GitHub master? maybe it only affects the 7.0.10 release branch? |
|
I think we can delete this package now. I don't think it is used. |
|
Assign to @adityapatwardhan to determine if this change should be merged. |
|
No this is not used anymore. The test packages created here were used for code coverage runs we used to run. We create these packages in release build for release automation testing. |
.vsts-ci/mac.yml
Outdated
| Import-Module .\tools\ci.psm1 | ||
| New-CodeCoverageAndTestPackage | ||
| displayName: CodeCoverage and Test Package | ||
| # this is no longer used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just delete this? We have history if we need to bring this back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
Handy links: |


PR Summary
Copying this change from release branch of v7.0.10
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).