X Tutup
The Wayback Machine - https://web.archive.org/web/20220812105426/https://github.com/PowerShell/PowerShell/pull/17221
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable broken macOS CI job, which is unused #17221

Merged
merged 2 commits into from May 16, 2022

Conversation

anmenaga
Copy link
Contributor

@anmenaga anmenaga commented Apr 28, 2022

PR Summary

Copying this change from release branch of v7.0.10

PR Checklist

Disable broken macOS CI job, which is unused
@daxian-dbw
Copy link
Member

daxian-dbw commented Apr 28, 2022

@anmenaga, @TravisEz13, the macOS daily build has been successful, for quite some time. Is the change in this PR really need to be ported to GitHub master? maybe it only affects the 7.0.10 release branch?

@TravisEz13
Copy link
Member

TravisEz13 commented Apr 29, 2022

I think we can delete this package now. I don't think it is used.

@daxian-dbw
Copy link
Member

daxian-dbw commented May 4, 2022

Assign to @adityapatwardhan to determine if this change should be merged.

@adityapatwardhan
Copy link
Member

adityapatwardhan commented May 6, 2022

No this is not used anymore. The test packages created here were used for code coverage runs we used to run. We create these packages in release build for release automation testing.

.vsts-ci/mac.yml Outdated
Import-Module .\tools\ci.psm1
New-CodeCoverageAndTestPackage
displayName: CodeCoverage and Test Package
# this is no longer used
Copy link
Member

@adityapatwardhan adityapatwardhan May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just delete this? We have history if we need to bring this back.

Copy link
Member

@TravisEz13 TravisEz13 May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@msftbot msftbot bot added the Waiting on Author label May 6, 2022
.vsts-ci/mac.yml Outdated Show resolved Hide resolved
@pull-request-quantifier
Copy link

pull-request-quantifier bot commented May 6, 2022

This PR has 13 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +0 -13
Percentile : 5.2%

Total files changed: 1

Change summary by file extension:
.yml : +0 -13

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan merged commit cc3b6fb into PowerShell:master May 16, 2022
48 checks passed
@adityapatwardhan adityapatwardhan added CL-BuildPackaging and removed Waiting on Author labels May 16, 2022
@msftbot
Copy link

msftbot bot commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.🎉

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-BuildPackaging Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
X Tutup