X Tutup
The Wayback Machine - https://web.archive.org/web/20221223135310/https://github.com/python/cpython/pull/96365
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96364: Fix text signatures of __getitem__ for list and dict #96365

Merged
merged 3 commits into from Sep 9, 2022
Merged

gh-96364: Fix text signatures of __getitem__ for list and dict #96365

merged 3 commits into from Sep 9, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 28, 2022 •
edited by bedevere-bot

After this change:

Python 3.12.0a0 (heads/main-dirty:e860e521ec, Aug 28 2022, 21:36:18) [Clang 11.0.0 (clang-1100.0.33.16)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> help(list.__getitem__)
Help on method_descriptor:

__getitem__(self, key, /)
    Return self[key].

>>> help(dict.__getitem__)
Help on method_descriptor:

__getitem__(self, key, /)
    Return self[key].

methane
methane reviewed Aug 29, 2022
View changes
Objects/listobject.c Outdated Show resolved Hide resolved
methane
methane reviewed Aug 31, 2022
View changes
Objects/listobject.c Outdated Show resolved Hide resolved
@methane methane merged commit 30cc190 into python:main Sep 9, 2022
14 checks passed
@sobolevn
Copy link
Member Author

sobolevn commented Sep 9, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

@markshannon markshannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sobolevn @methane @bedevere-bot
X Tutup