X Tutup
The Wayback Machine - https://web.archive.org/web/20250615050754/https://github.com/python/cpython/pull/96315
Skip to content

gh-96308: Use __phello__ module for test rather than importlib #96315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

gh-96308: Use __phello__ module for test rather than importlib #96315

wants to merge 4 commits into from

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Aug 26, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Aug 26, 2022
@sweeneyde sweeneyde added the needs backport to 3.11 only security fixes label Aug 26, 2022
@sweeneyde
Copy link
Member Author

I verified that this test passes after the fix at b156578 , but fails just before the fix, at 04dc4b0 .

@ericsnowcurrently
Copy link
Member

CC @markshannon @brandtbucher

@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.11 only security fixes labels May 9, 2024
@kulikjak kulikjak mentioned this pull request Nov 27, 2024
Closed
@vstinner
Copy link
Member

IMO this change is no longer needed since commit 276d777:

commit 276d77724f2373cc03838448a3e62977aa28bf0d
Author: Brandt Bucher <brandtbucher@microsoft.com>
Date:   Wed Nov 2 10:42:57 2022 -0700

    GH-98686: Quicken everything (GH-98687)

Extract of the change:

+            # "copy" the code to un-specialize it:
+            func.__code__ = func.__code__.replace()
+
+            assert not is_specialized(func), "specialized instructions found"

This PR is no longer needed and has conflict, I close it.

@vstinner vstinner closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sweeneyde @ericsnowcurrently @vstinner @serhiy-storchaka @bedevere-bot
X Tutup