X Tutup
The Wayback Machine - https://web.archive.org/web/20250617140305/https://github.com/python/cpython/pull/96233
Skip to content

gh-45108: Improve docstring and testing of ZipFile.testfile() #96233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2022
Merged

gh-45108: Improve docstring and testing of ZipFile.testfile() #96233

merged 1 commit into from
Sep 3, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 24, 2022 •
edited by bedevere-bot
Loading

Based on patches proposed in #45108.

Differences with the last version of the patch:

  • The docstring has been reformatted. The first line should be a short summary.
  • Fixed multiple conflicts.
  • Added yet one assert.
  • Removed testziptest. Corresponding asserts are already included in other tests.
  • Changes related to close() was already made.
  • File TESTFN no longer used in test_zipfile64.TestsWithSourceFile.

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Aug 24, 2022
@serhiy-storchaka
Copy link
Member Author

Seems the list of differences with the last version of the patch is larger than the list of changes actually made by this PR.

@serhiy-storchaka serhiy-storchaka merged commit 16c6759 into python:main Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @iritkatriel @gvanrossum @bedevere-bot
X Tutup