X Tutup
The Wayback Machine - https://web.archive.org/web/20220903085626/https://github.com/python/cpython/pull/1687
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30419: DOC: Update missing information in bdb docs #1687

Merged
merged 9 commits into from Sep 2, 2022
Merged

bpo-30419: DOC: Update missing information in bdb docs #1687

merged 9 commits into from Sep 2, 2022
+133 −65

Conversation

csabella
Copy link
Contributor

@csabella csabella commented May 20, 2017 •
edited by JelleZijlstra

Update missing information identified when creating docstrings.

#74604

@mention-bot
Copy link

mention-bot commented May 20, 2017

@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @benjaminp and @birkenfeld to be potential reviewers.

@vstinner
Copy link
Member

vstinner commented May 21, 2017

I'm sorry but it seems that you mentionned the wrong bpo number.

@csabella csabella changed the title bpo-30409: DOC: Update missing information in bdb docs bpo-30419: DOC: Update missing information in bdb docs May 21, 2017
@csabella
Copy link
Contributor Author

csabella commented May 21, 2017

Sorry about that, it was 30419.

terryjreedy
terryjreedy requested changes Jun 5, 2017
View changes
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
vadmium
vadmium reviewed Jun 6, 2017
View changes
Copy link
Member

@vadmium vadmium left a comment

I’m not familiar with this particular module, but I found a couple places with apparently unfinished sentences (or at that least don’t make grammatical sense to me).

Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
@brettcannon
Copy link
Member

brettcannon commented Feb 2, 2018

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

@aeros aeros added the stale Stale PR or inactive for long period of time. label Sep 10, 2019
@AlexWaygood AlexWaygood added the docs Documentation in the Doc dir label Apr 11, 2022
JelleZijlstra
JelleZijlstra reviewed May 8, 2022
View changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

This PR has had quite the journey. I think it's mostly a good improvement, but I have a few comments.

Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
Doc/library/bdb.rst Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra self-assigned this May 8, 2022
@JelleZijlstra @vadmium
Apply suggestions from code review
d51e3df 
Co-authored-by: Martin Panter <vadmium@users.noreply.github.com>
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Aug 28, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2022
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Aug 29, 2022

@terryjreedy are you OK with merging this now? You requested changes several years ago.

@terryjreedy
Copy link
Member

terryjreedy commented Aug 29, 2022

Yes, go ahead. And thank you for finishing this.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 30, 2022
tiran
tiran previously requested changes Sep 2, 2022
View changes
Copy link
Member

@tiran tiran left a comment

Please fix the trailing white spaces (make patchcheck)

@python python deleted a comment from bedevere-bot Sep 2, 2022
@terryjreedy terryjreedy dismissed tiran’s stale review Sep 2, 2022

Whitespace fixed

@terryjreedy terryjreedy merged commit ccce9b7 into python:main Sep 2, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 2, 2022

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 2, 2022

GH-96514 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

bedevere-bot commented Sep 2, 2022

GH-96515 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 2, 2022
@csabella @miss-islington
bpo-30419: DOC: Update missing information in bdb docs (pythonGH-1687)
6584cf9 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Martin Panter <vadmium@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ccce9b77e1f599e05425eadc0cc372d142fe05e0)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 2, 2022
@csabella @miss-islington
bpo-30419: DOC: Update missing information in bdb docs (pythonGH-1687)
50c5a2b 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Martin Panter <vadmium@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ccce9b77e1f599e05425eadc0cc372d142fe05e0)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this issue Sep 2, 2022
@miss-islington @csabella
bpo-30419: DOC: Update missing information in bdb docs (GH-1687)
02c59be 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Martin Panter <vadmium@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ccce9b7)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this issue Sep 2, 2022
@miss-islington @csabella
bpo-30419: DOC: Update missing information in bdb docs (GH-1687)
cb39a44 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Martin Panter <vadmium@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ccce9b7)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmium vadmium

@JelleZijlstra JelleZijlstra

@terryjreedy terryjreedy

@tiran tiran

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
X Tutup