X Tutup
The Wayback Machine - https://web.archive.org/web/20220409062957/https://github.com/nodejs/node/pull/42498
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update GHA actions version #42498

Merged
merged 1 commit into from Mar 30, 2022
Merged

tools: update GHA actions version #42498

merged 1 commit into from Mar 30, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 27, 2022

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 27, 2022

Review requested:

@nodejs-github-bot nodejs-github-bot added the meta label Mar 27, 2022
@mscdex
Copy link
Contributor

@mscdex mscdex commented Mar 27, 2022

Duplicate of #42460 ?

@aduh95
Copy link
Contributor Author

@aduh95 aduh95 commented Mar 27, 2022 •
edited

Duplicate of #42460 ?

Oh I missed this PR, thanks for linking to it. You’re right it’s overlapping but not exactly duplicate: #42460 is only updating actions/checkout from what I can see, my PR is updating other actions as well (setup-python, setup-node, etc.)

@UltiRequiem
Copy link
Contributor

@UltiRequiem UltiRequiem commented Mar 28, 2022

Duplicate of #42460 ?

Oh I missed this PR, thanks for linking to it. You’re right it’s overlapping but not exactly duplicate: #42460 is only updating actions/checkout from what I can see, my PR is updating other actions as well (setup-python, setup-node, etc.)

Probably better to do it in separate PR, eg tools: update setup-python GHA and tools: update setup-node GHA so is easier to review.

Trott
Trott approved these changes Mar 28, 2022
View changes
Copy link
Member

@Trott Trott left a comment •
edited

Subsystem should be build: rather than tools: in the commit message, or at least that's what we've always usually used in the past for .github/workflows.

@Trott Trott added the author ready label Mar 28, 2022
@aduh95 aduh95 added the commit-queue label Mar 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue label Mar 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit d320d45 into nodejs:master Mar 30, 2022
27 checks passed
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 30, 2022

Landed in d320d45

@aduh95 aduh95 deleted the upgrade-gha branch Mar 30, 2022
juanarbol added a commit that referenced this issue Apr 4, 2022
@aduh95 @juanarbol
tools: update GHA actions version
e59bd6f 
PR-URL: #42498
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol added a commit to juanarbol/node that referenced this issue Apr 5, 2022
@aduh95 @juanarbol
tools: update GHA actions version
1670266 
PR-URL: nodejs#42498
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarbol juanarbol mentioned this pull request Apr 5, 2022
Closed
@juanarbol juanarbol mentioned this pull request Apr 5, 2022
Merged
juanarbol added a commit that referenced this issue Apr 6, 2022
@aduh95 @juanarbol
tools: update GHA actions version
bff9cae 
PR-URL: #42498
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@benjamingr benjamingr

@lpinca lpinca

@Mesteery Mesteery

Assignees
No one assigned
Labels
author ready meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@aduh95 @nodejs-github-bot @mscdex @UltiRequiem @Trott @benjamingr @lpinca @Mesteery
X Tutup