Use error codes for type ignores #8280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable reportSelfClsParameterName for pytype as this is out of typeshed's control Closes: python#7497
AlexWaygood
reviewed
Jul 12, 2022
AlexWaygood
reviewed
Jul 12, 2022
AlexWaygood
reviewed
Jul 12, 2022
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. |
AlexWaygood
added a commit
that referenced
this issue
Jul 12, 2022
This wasn't possible prior to #8280, which disabled pyright's reportSelfClsParameterName check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Disable reportSelfClsParameterName for pyright as this is out of typeshed's
control
Closes: #7497