gh-94731: Revert to C-style casts for _Py_CAST #94782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: da-woods <dw-git@d-woods.co.uk>
encukou
added
the
bedevere-bot
removed
the
We have buildbots like that...
encukou
added
the
bedevere-bot
removed
the
da-woods
reviewed
Jul 13, 2022
Lib/test/_testcppext.cpp
Outdated
| PyObject *ipotype = PyType_FromSpec(&VirtualPyObject_Spec); | ||
| // no good way to signal failure from a C++ constructor, so use assert | ||
| // for error handling | ||
| assert(ipotype); | ||
| assert(PyObject_Init(this, (PyTypeObject *)ipotype)); | ||
| Py_DECREF(ipotype); |
There was a problem hiding this comment.
Suggested change
| PyObject *ipotype = PyType_FromSpec(&VirtualPyObject_Spec); | |
| // no good way to signal failure from a C++ constructor, so use assert | |
| // for error handling | |
| assert(ipotype); | |
| assert(PyObject_Init(this, (PyTypeObject *)ipotype)); | |
| Py_DECREF(ipotype); | |
| PyObject *vpotype = PyType_FromSpec(&VirtualPyObject_Spec); | |
| // no good way to signal failure from a C++ constructor, so use assert | |
| // for error handling | |
| assert(vpotype); | |
| assert(PyObject_Init(this, (PyTypeObject *)vpotype)); | |
| Py_DECREF(vpotype); |
Just suggesting changing the name slightly here to match the name you used from the class. I think the i from ipotype was a hold-over from the name I used.
There was a problem hiding this comment.
Thanks! It's a local variable now so I'll just name it type :)
encukou
added
the
bedevere-bot
removed
the
|
Thanks @encukou for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2022
Co-authored-by: da-woods <dw-git@d-woods.co.uk> (cherry picked from commit 6cbb57f) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
GH-94849 is a backport of this pull request to the 3.11 branch. |
encukou
pushed a commit
that referenced
this pull request
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reverts some changes from #91321