X Tutup
The Wayback Machine - https://web.archive.org/web/20220808232541/https://github.com/python/cpython/pull/95735
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in test_dataclasses.py #95735

Merged
merged 1 commit into from Aug 6, 2022
Merged

Fix typo in test_dataclasses.py #95735

merged 1 commit into from Aug 6, 2022

Conversation

da-woods
Copy link
Contributor

@da-woods da-woods commented Aug 6, 2022

dataclass was called as a function when it was almost certainly intended to be a decorator.

(I don't believe this needs an issue or a news entry)

`dataclass` was called as a function when it was almost certainly intended to be a decorator.

(I don't believe this needs an issue or a news entry)
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Nice catch!

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2022

Thanks @da-woods for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 6, 2022
`dataclass` was called as a function when it was almost certainly intended to be a decorator.
(cherry picked from commit 59e09ef)

Co-authored-by: da-woods <dw-git@d-woods.co.uk>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 6, 2022

GH-95740 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 6, 2022
`dataclass` was called as a function when it was almost certainly intended to be a decorator.
(cherry picked from commit 59e09ef)

Co-authored-by: da-woods <dw-git@d-woods.co.uk>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 6, 2022

GH-95741 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this issue Aug 6, 2022
`dataclass` was called as a function when it was almost certainly intended to be a decorator.
(cherry picked from commit 59e09ef)

Co-authored-by: da-woods <dw-git@d-woods.co.uk>
@da-woods da-woods deleted the patch-1 branch Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants
X Tutup