X Tutup
The Wayback Machine - https://web.archive.org/web/20221223104813/https://github.com/python/cpython/pull/95072
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95066: ast: Replace assert with ValueError #95072

Merged
merged 3 commits into from Jul 26, 2022
Merged

gh-95066: ast: Replace assert with ValueError #95072

merged 3 commits into from Jul 26, 2022

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Jul 20, 2022 •
edited by bedevere-bot

@hauntsaninja hauntsaninja requested a review from isidentical as a code owner Jul 20, 2022
@hauntsaninja hauntsaninja changed the title gh-95066: ast: Replace AssertionError with ValueError gh-95066: ast: Replace assert with ValueError Jul 20, 2022
erlend-aasland
erlend-aasland approved these changes Jul 21, 2022
View changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

LGTM; thanks Shantanu.

@ambv ambv merged commit a5dde0f into python:main Jul 26, 2022
14 checks passed
@ambv ambv mentioned this pull request Jul 26, 2022
Closed
@hauntsaninja hauntsaninja deleted the gh-95066 branch Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellDupre MaxwellDupre

@erlend-aasland erlend-aasland

@isidentical isidentical

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hauntsaninja @erlend-aasland @MaxwellDupre @ambv @bedevere-bot
X Tutup