bpo-28249: fix lineno location for empty DocTest instances
#30498
+83
鈭�6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
reviewed
Jan 9, 2022
kumaraditya303
reviewed
Jan 10, 2022
Misc/NEWS.d/next/Library/2022-01-09-14-23-00.bpo-28249.4dzB80.rst
Outdated
Show resolved
Hide resolved
|
This PR is stale because it has been open for 30 days with no activity. |
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
I rebased and resolved a conflict with |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
May 19, 2022
鈥GH-30498) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> Co-authored-by: 艁ukasz Langa <lukasz@langa.pl> (cherry picked from commit 8db2b3b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
Sorry, @sobolevn and @ambv, I could not cleanly backport this to |
|
Sorry @sobolevn and @ambv, I had trouble checking out the |
|
GH-92978 is a backport of this pull request to the 3.11 branch. |
ambv
pushed a commit
to ambv/cpython
that referenced
this issue
May 19, 2022
鈥ythonGH-30498) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> Co-authored-by: 艁ukasz Langa <lukasz@langa.pl> (cherry picked from commit 8db2b3b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ambv
pushed a commit
to ambv/cpython
that referenced
this issue
May 19, 2022
鈥ythonGH-30498) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> Co-authored-by: 艁ukasz Langa <lukasz@langa.pl> (cherry picked from commit 8db2b3b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-92981 is a backport of this pull request to the 3.10 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This patch fixes
linenoforDocTestinstances for objects that don't have__doc__attribute.In the original issue this was used as an example:
Before this patch,
doctest.DocTestFinder(exclude_empty=False).find(example_module)was showing:Notice that
linenowas5forexampleandexample.a. Which is clearly wrong, becauseexample.bis on the 5th line. But,example.chadlineno=None.DocTestdocs clearly state:So, now
linenois set toNonewhen__doc__cannot be found. Now, the result for ourexamplemodule will be:Now, everything looks correct.
https://bugs.python.org/issue28249
CC @corona10 as my mentor馃檪