X Tutup
The Wayback Machine - https://web.archive.org/web/20220513133403/https://github.com/python/peps/pull/2601
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 623: Change status to Final #2601

Merged
merged 3 commits into from May 13, 2022
Merged

PEP 623: Change status to Final #2601

merged 3 commits into from May 13, 2022
+3 −1

Conversation

methane
Copy link
Member

@methane methane commented May 12, 2022

Implemented in python/cpython#92537

AA-Turner
AA-Turner approved these changes May 12, 2022
View changes
Copy link
Member

@AA-Turner AA-Turner left a comment

I noticed that there is no Resolution header for the PEP.
We should add that either in this PR or a follow-up.

A

@hugovk
Copy link
Member

@hugovk hugovk commented May 12, 2022

And a Discussions-To with https://mail.python.org/archives/list/python-dev@python.org/thread/S7KW2U6IGXZFBMGS6WSJB26NZIBW4OLE/ ?

@CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented May 12, 2022

This thread is the resolution.

Its hard to be sure since the text is somewhat ambiguous and highly technical, but it sounds like that thread is not actually about PEP 623 itself, which concerns only the APIs using the wstr Unicode struct member, while the other APIs are stated to be out of scope by the PEP, whereas the thread is titled "Plan to remove Py_UNICODE APIs except PEP 623" and lists a different set of objects to be removed than the PEP does. However, I can't find any thread about PEP 623 either searching Python-Dev or Discourse. There's this thread on the related PEP 624, but that's a separate PEP.

Inada-san, could you help us out with a link to the thread? Or @vstinner ?

vstinner
vstinner approved these changes May 12, 2022
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.

@methane methane merged commit 9111678 into python:main May 13, 2022
4 checks passed
@methane methane deleted the pep623 branch May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@AA-Turner AA-Turner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@methane @hugovk @CAM-Gerlach @vstinner @AA-Turner
X Tutup