X Tutup
The Wayback Machine - https://web.archive.org/web/20220723032614/https://github.com/TheAlgorithms/Python/pull/6230
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Updated f-string method #6230

Merged
merged 11 commits into from Jul 7, 2022
Merged

MAINT: Updated f-string method #6230

merged 11 commits into from Jul 7, 2022

Conversation

cyai
Copy link
Contributor

@cyai cyai commented Jul 5, 2022

Describe your change:

Updated the code with f-string methods wherever required for a better and cleaner understanding of the code.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cyai
MAINT: Used f-string method
13ceb2b 
Updated the code with f-string methods wherever required for a better and cleaner understanding of the code.
@algorithms-keeper algorithms-keeper bot added enhancement awaiting reviews labels Jul 5, 2022
@cyai
Merge pull request #1 from cyai/cyai-patch-1
372350a 
MAINT: Used f-string method
@cclauss
Copy link
Member

@cclauss cclauss commented Jul 6, 2022

Please flynt the entire repo https://pypi.org/project/flynt/

@cyai
Copy link
Contributor Author

@cyai cyai commented Jul 6, 2022

Updated the entire repo

@algorithms-keeper algorithms-keeper bot added the tests are failing label Jul 6, 2022
@cclauss
Copy link
Member

@cclauss cclauss commented Jul 7, 2022

Please fix the failing test when you get a chance.

cclauss
cclauss reviewed Jul 7, 2022
View changes
ciphers/rsa_key_generator.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Jul 7, 2022
View changes
ciphers/elgamal_key_generator.py Outdated Show resolved Hide resolved
@cclauss
Copy link
Member

@cclauss cclauss commented Jul 7, 2022

OK... psf/black is happy but now flake8 is complaining:

other/lru_cache.py:24:89: E501 line too long (126 > 88 characters)

@cyai
Copy link
Contributor Author

@cyai cyai commented Jul 7, 2022

I don't think that's an error in the python code, it is the error thrown by compiler!

@cclauss
Copy link
Member

@cclauss cclauss commented Jul 7, 2022 •
edited

flake8 is a linter, not a compiler.

return (
            f"Node: key: {self.key}, val: {self.val}, "
            f"has next: {bool(self.next)}, has prev: {bool(self.prev}"
        )

cyai and others added 3 commits Jul 7, 2022
@cyai
Update lru_cache.py
a5b1b23 
I don't think this change is efficient but it might tackle the error as the error was due to using long character lines.
@cclauss
Update lru_cache.py
0735dc8
@cyai
Update lru_cache.py
86cc9b0
cclauss
cclauss approved these changes Jul 7, 2022
View changes
Copy link
Member

@cclauss cclauss left a comment

Thanks for doing this!

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews label Jul 7, 2022
cclauss
cclauss approved these changes Jul 7, 2022
View changes
@algorithms-keeper algorithms-keeper bot removed the tests are failing label Jul 7, 2022
@cclauss cclauss merged commit 2d5dd6f into TheAlgorithms:master Jul 7, 2022
2 checks passed
@cyai
Copy link
Contributor Author

@cyai cyai commented Jul 7, 2022

Thanks, for merging and helping. Much appriciated.🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cyai @cclauss
X Tutup