X Tutup
The Wayback Machine - https://web.archive.org/web/20250614082132/https://github.com/python/cpython/pull/94341
Skip to content

gh-94340: Add function to convert datetime object to year and quarter #94341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Godskid89
Copy link

@Godskid89 Godskid89 commented Jun 27, 2022

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not qualified to review this but tests would help maybe to even understand what this code is doing.

@pganssle
Copy link
Member

pganssle commented Oct 7, 2022

I don't think it's especially likely that we would want to accept this feature as is anyway. It might be reasonable as an extension to the strftime formatting, but it would need discussion in an issue, and I'd warn that that sort of thing usually can take a long time if it happens at all.

We should close this PR, but thank you for taking the time to contribute to CPython @Godskid89.

@pganssle pganssle closed this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
X Tutup