X Tutup
The Wayback Machine - https://web.archive.org/web/20220526020439/https://github.com/faker-js/faker/issues/339
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move random.word to word.any #339

Open
pkuczynski opened this issue Jan 28, 2022 · 6 comments · May be fixed by #714
Open

Move random.word to word.any #339

pkuczynski opened this issue Jan 28, 2022 · 6 comments · May be fixed by #714
Assignees
@pkuczynski
Labels
c: feature good first issue
Milestone
v7 - Current Major

Comments

@pkuczynski
Copy link
Member

@pkuczynski pkuczynski commented Jan 28, 2022

Clear and concise description of the problem

Most of the methods of random already found their new home, like random.number > datatype.number

Suggested solution

Move random.word to word.any and deprecate random.word.

Alternative

No response

Additional context

#276 (comment)
@pkuczynski pkuczynski added s: pending triage c: feature good first issue labels Jan 28, 2022
@pkuczynski pkuczynski added this to the v6.2 - New small features milestone Jan 28, 2022
@github-actions github-actions bot removed the s: pending triage label Jan 28, 2022
@pkuczynski pkuczynski mentioned this issue Jan 28, 2022
Closed
@andrewgremlich
Copy link

@andrewgremlich andrewgremlich commented Jan 29, 2022

I'll take this! Simple enough.

@andrewgremlich
Copy link

@andrewgremlich andrewgremlich commented Jan 29, 2022

I see this PR though... should I wait until that is merged? #276

@pkuczynski
Copy link
Member Author

@pkuczynski pkuczynski commented Jan 30, 2022

I see this PR though... should I wait until that is merged? #276

In principle no changes like this will be merged until 6.0 is released. So I would wait with this, yes.

@andrewgremlich
Copy link

@andrewgremlich andrewgremlich commented Mar 28, 2022

Since 6.0 was released, I'll continue with this one!

@pkuczynski
Copy link
Member Author

@pkuczynski pkuczynski commented Mar 28, 2022

Since 6.0 was released, I'll continue with this one!

Please don't. It has been already discussed and I am on it.

@andrewgremlich
Copy link

@andrewgremlich andrewgremlich commented Mar 28, 2022

Sounds good!

@pkuczynski pkuczynski self-assigned this Mar 28, 2022
@pkuczynski pkuczynski linked a pull request Mar 28, 2022 that will close this issue
Open
@Shinigami92 Shinigami92 removed this from the v6.2 - New small features milestone Apr 21, 2022
@Shinigami92 Shinigami92 added this to the v6.3 - Next Minor milestone Apr 21, 2022
@Shinigami92 Shinigami92 removed this from the v6.3 - Next Minor milestone May 2, 2022
@Shinigami92 Shinigami92 added this to the v7.0 - Next Minor milestone May 2, 2022
@Shinigami92 Shinigami92 removed this from the v7.0 - Next Minor milestone May 3, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkuczynski pkuczynski

Labels
c: feature good first issue
Projects
Faker Roadmap
Status: In Progress
Milestone
v7 - Current Major
Development

Successfully merging a pull request may close this issue.

feat: new method faker.word.any pkuczynski/faker
3 participants
@pkuczynski @Shinigami92 @andrewgremlich
X Tutup