X Tutup
The Wayback Machine - https://web.archive.org/web/20221223152537/https://github.com/python/cpython/pull/94051
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-90699: Move generated static initializer to pycore_runtime_generated.h #94051

Merged
merged 3 commits into from Jul 7, 2022
Merged

GH-90699: Move generated static initializer to pycore_runtime_generated.h #94051

merged 3 commits into from Jul 7, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 21, 2022 •
edited by miss-islington

Automerge-Triggered-By: GH:ericsnowcurrently

@kumaraditya303 kumaraditya303 requested a review from a team as a code owner Jun 21, 2022
@kumaraditya303 kumaraditya303 changed the title GH-90699: Move generated static intializer to pycore_runtime_generated.h GH-90699: Move generated static initializer to pycore_runtime_generated.h Jun 21, 2022
@kumaraditya303 kumaraditya303 mentioned this pull request Jun 24, 2022
Merged
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Jul 5, 2022

Is this related to #93597 (comment)?

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Jul 6, 2022

Is this related to #93597 (comment)?

Yes.

ericsnowcurrently
ericsnowcurrently approved these changes Jul 6, 2022
View changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

LGTM

I'm approving the PR but left a couple non-critical comments which I'd like resolved (at least an agreement that what you have is okay) before merging.

Include/internal/pycore_runtime_init.h Outdated Show resolved Hide resolved
Include/internal/pycore_runtime_generated.h Outdated Show resolved Hide resolved
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Jul 6, 2022

Are you going to do something similar for the generated code in pycore_global_strings.h?

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Jul 7, 2022

Are you going to do something similar for the generated code in pycore_global_strings.h?

I will probably merge the generated code from pycore_global_strings.h in the same file as this one but that's for another day.

@ericsnowcurrently ericsnowcurrently added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jul 7, 2022
@miss-islington miss-islington merged commit 7169766 into python:main Jul 7, 2022
12 checks passed
@kumaraditya303 kumaraditya303 deleted the generated branch Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kumaraditya303 @ericsnowcurrently @bedevere-bot @miss-islington
X Tutup