X Tutup
The Wayback Machine - https://web.archive.org/web/20220607124918/https://github.com/PowerShell/PowerShell/pull/14906
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev container #14906

Merged
merged 4 commits into from Mar 8, 2021
Merged

Fix dev container #14906

merged 4 commits into from Mar 8, 2021

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Feb 26, 2021

PR Summary

The image appeared to be wrong. This fixes it to a working image (although I'm not sure if it's the correct one).

PR Context

Now you can properly use GitHub Codespaces :)

PR Checklist

@msftbot msftbot bot added the Review - Needed label Mar 5, 2021
@msftbot
Copy link

@msftbot msftbot bot commented Mar 5, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Mar 5, 2021

@TravisEz13 @adityapatwardhan or @JamesWTruher I need someone to review this PR to work out if this is the right fix for the PS dev container for codespaces

@msftbot msftbot bot removed the Review - Needed label Mar 5, 2021
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@TravisEz13 TravisEz13 merged commit 6cfdbaa into PowerShell:master Mar 8, 2021
31 checks passed
@TylerLeonhardt TylerLeonhardt deleted the codespace-504c branch Mar 8, 2021
@TravisEz13 TravisEz13 added the CL-NotInBuild label Mar 16, 2021
@TravisEz13 TravisEz13 added this to the 7.2.0-preview.4 milestone Mar 16, 2021
@Montaserbdrelden25
Copy link

@Montaserbdrelden25 Montaserbdrelden25 commented Apr 29, 2022

TylerLeonhardt:codespace-504c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-NotInBuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
X Tutup