X Tutup
The Wayback Machine - https://web.archive.org/web/20220607170532/https://github.com/python/cpython/pull/93574
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-93573: Replace bytebong.com by python.org #93574

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sblondon
Copy link
Contributor

@sblondon sblondon commented Jun 7, 2022

This minor PR replaces bytebong.com to python.org in configparser example in order to use a domain the PSF controls.

topsecret.server.com is obviously an example and I don't think bitbucket.org is a risk currently so they are not modified.

@bedevere-bot bedevere-bot added docs awaiting review labels Jun 7, 2022
@arhadthedev
Copy link
Contributor

@arhadthedev arhadthedev commented Jun 7, 2022

topsecret.server.com

Maybe, topsecret.example.com would be better?

@tiran
Copy link
Member

@tiran tiran commented Jun 7, 2022

Documentation should use reserved TLDs from https://datatracker.ietf.org/doc/html/rfc2606, e.g. topsecret.python.example.

topsecret.server.com domain is not controled by PSF. It's replaced by invalid topsecret.server.example domain. It follows RFC 2606, which advise .example as TLD for documentation.
@sblondon
Copy link
Contributor Author

@sblondon sblondon commented Jun 7, 2022

I replaced topsecret.server.com by topsecret.server.example so the difference between topsecret.server.example and python.org assertions are more obvious.

I don't think news are needed.

Copy link
Member

@AA-Turner AA-Turner left a comment

If we're changing to .example, it might also be worth changing the bitbucket.org ones? I know the domain is currently active, but extra safety doesn't hurt.

A

@sblondon
Copy link
Contributor Author

@sblondon sblondon commented Jun 7, 2022

bitbucket.org domain is now replaced by forge.example.

Copy link
Member

@AA-Turner AA-Turner left a comment

Thanks!

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants
X Tutup