X Tutup
The Wayback Machine - https://web.archive.org/web/20250520122919/https://github.com/angular/angular/pull/46176
Skip to content

docs: update build section to include autoprefixer link. #46176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rahulkumarsingh73690
Copy link

Added online version of Autoprefixer. So users can instantly use it without installing it.

Added online version of Autoprefixer. So users can instantly use it without installing it.
@pullapprove pullapprove bot requested a review from alan-agius4 May 29, 2022 08:33
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Can you please update the commit message as per guidelines? Thanks.

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: docs target: patch This PR is targeted for the next patch release labels May 30, 2022
@ngbot ngbot bot modified the milestone: Backlog May 30, 2022
@rahulkumarsingh73690
Copy link
Author

Thanks for this.

Can you please update the commit message as per guidelines? Thanks.

Isn’t this already follow all guidelines.

None of these are official but I recommend this one (https://goonlinetools.com/autoprefixer/) because it highlights css code error and both works on latest autoprefixer and postcss.

Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should have docs: as type example.
docs: update build section to include autoprefixer link.

Thinking a bit more, I think it would be better to actually link to the autoprefixer docs (https://github.com/postcss/autoprefixer) which do include a link to a REPL. I think in this case users would expect that the link points tool docs based on the context of the paragraph. I'd expect a link to a REPL, if the wording mentions this.

@rahulkumarsingh73690
Copy link
Author

rahulkumarsingh73690 commented May 30, 2022

The commit message should have docs: as type example. docs: update build section to include autoprefixer link.

Thinking a bit more, I think it would be better to actually link to the autoprefixer docs (https://github.com/postcss/autoprefixer) which do include a link to a REPL. I think in this case users would expect that the link points tool docs based on the context of the paragraph. I'd expect a link to a REPL, if the wording mentions this.

Official docs is already linked from above angular doc. So it doesn’t make sense

@rahulkumarsingh73690 rahulkumarsingh73690 changed the title Added online version of autoprefixer. docs: update build section to include autoprefixer link. May 30, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Jun 24, 2022

As Alan said above, it's probably OK just to link to the official docs, rather than a third party online service directly.

@dylhunn dylhunn closed this Jun 24, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
X Tutup