New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve hashtable completion #16498
Improve hashtable completion #16498
Conversation
…ady in a hashtable and add argument completers for Get-WinEvent and Invoke-CimMethod
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
…ameter for Cim cmdlets.
src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs
Outdated
Show resolved
Hide resolved
|
@daxian-dbw can you have a look? |
Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
I understand if you are busy, to help prioritize I will say that out of all my open PRs, this is the one I'm most interested in seeing in the near future. It's just so convenient being able to tab complete parameters in splatting hashtables. |
|
@MartinGC94 Sorry for the long delay on this. I will get to this PR this week. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Sorry for the delay on review.
The changes overall look good. Thanks for the improvements!
src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
The |
|
Handy links: |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.



PR Summary
Fixes a few things about hashtable completion:
Example of a scenario that currently fails, but will get fixed by this PR:
Also adds completers for the
Argumentsparameter forInvoke-CimMethodtheFilterHashtableparameter forGet-WinEventthe PropertyParameterfor the cim cmdlets and the standard cim completers for Set-CimInstance.This also removes duplicates from member completion in scenarios like
ls | select Attributes,<Cursor here>this could be split off into its own PR but since it depends on changes made in this PR I thought I may as well include it here.Finally it adds some basic completion support for hashtables used for splatting. The pseudo binding doesn't take the hashtable parameters into account so it's not perfect but IMO some completion is better than none.
Fixes #9239
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).