X Tutup
The Wayback Machine - https://web.archive.org/web/20250616094945/https://github.com/localstack/localstack/pull/6041
Skip to content

Cleanup replay-based persistence #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 1, 2022
Merged

Cleanup replay-based persistence #6041

merged 5 commits into from
Jul 1, 2022

Conversation

giograno
Copy link
Member

This PR removes the code related to the record/replay-based persistence feature. It impacts this.

@giograno giograno requested a review from thrau as a code owner May 10, 2022 16:17
@giograno giograno temporarily deployed to localstack-ext-tests May 10, 2022 16:17 Inactive
@github-actions
Copy link

github-actions bot commented May 10, 2022 •
edited
Loading

LocalStack integration with Pro

       3 files         3 suites   1h 4m 11s ⏱️
1 115 tests 1 076 ✔️ 39 💤 0 ❌
1 426 runs  1 358 ✔️ 68 💤 0 ❌

Results for commit 4ab524f.

♻️ This comment has been updated with latest results.

@giograno giograno marked this pull request as draft May 10, 2022 18:45
@giograno giograno added the area: persistence Retain state between LocalStack runs label May 17, 2022
@giograno giograno force-pushed the persistence-code-cleanup branch from 3f43f2d to f1685a3 Compare May 17, 2022 14:17
@giograno giograno temporarily deployed to localstack-ext-tests May 17, 2022 14:18 Inactive
@github-actions github-actions bot added size/m aws:s3 Amazon Simple Storage Service aws:sns Amazon Simple Notification Service aws:sqs Amazon Simple Queue Service labels May 17, 2022
@giograno giograno temporarily deployed to localstack-ext-tests May 17, 2022 14:22 Inactive
@giograno giograno temporarily deployed to localstack-ext-tests May 17, 2022 14:55 Inactive
@giograno giograno marked this pull request as ready for review May 17, 2022 15:35
@giograno giograno force-pushed the persistence-code-cleanup branch from effdf71 to 211d43d Compare May 19, 2022 13:48
@giograno giograno temporarily deployed to localstack-ext-tests May 19, 2022 13:48 Inactive
@github-actions github-actions bot removed the aws:sqs Amazon Simple Queue Service label May 19, 2022
@thrau thrau force-pushed the persistence-code-cleanup branch from 211d43d to 28c9a52 Compare May 25, 2022 18:36
@thrau
Copy link
Member

thrau commented May 25, 2022

rebased the branch

@thrau thrau temporarily deployed to localstack-ext-tests May 25, 2022 18:36 Inactive
@giograno
Copy link
Member Author

@thrau integration with pro will fail cause we call some functions that do not exists anymore (see https://github.com/localstack/localstack-ext/pull/601)

@silv-io silv-io removed the size/m label Jun 13, 2022
@giograno giograno changed the base branch from master to v1 June 30, 2022 08:53
@giograno giograno requested a review from bentsku as a code owner June 30, 2022 08:53
@giograno giograno force-pushed the persistence-code-cleanup branch from 28c9a52 to a5c1cc9 Compare June 30, 2022 09:12
@giograno giograno temporarily deployed to localstack-ext-tests June 30, 2022 09:12 Inactive
@giograno giograno temporarily deployed to localstack-ext-tests June 30, 2022 09:32 Inactive
@localstack-bot localstack-bot force-pushed the persistence-code-cleanup branch from 2dd088e to 974c6d0 Compare June 30, 2022 09:44
@localstack-bot localstack-bot temporarily deployed to localstack-ext-tests June 30, 2022 09:45 Inactive
@giograno giograno self-assigned this Jun 30, 2022
alexrashed
alexrashed approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
The only question is if the replay persistence should be removed with v1 or maybe prior to that (because there might be another release before v1).
It has been deprecated for a long time already though, so I'm fine with both.

@giograno
Copy link
Member Author

Good point @alexrashed. We already did announce in 0.14.3 that we would have removed it in the next release. I do not have strong opinions about it. What do you think @thrau?

@localstack-bot localstack-bot force-pushed the persistence-code-cleanup branch from 974c6d0 to 4ab524f Compare June 30, 2022 20:47
@localstack-bot localstack-bot temporarily deployed to localstack-ext-tests June 30, 2022 20:47 Inactive
@localstack-bot localstack-bot force-pushed the persistence-code-cleanup branch from 4ab524f to 4b6e4e0 Compare July 1, 2022 09:58
thrau
thrau approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! let's merge into v1

@thrau thrau merged commit 9204116 into v1 Jul 1, 2022
@thrau thrau deleted the persistence-code-cleanup branch July 1, 2022 14:27
@localstack localstack locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@thrau thrau thrau approved these changes

@bentsku bentsku Awaiting requested review from bentsku

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@dfangl dfangl Awaiting requested review from dfangl

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni

@silv-io silv-io Awaiting requested review from silv-io

Assignees

@giograno giograno

Labels
area: persistence Retain state between LocalStack runs aws:s3 Amazon Simple Storage Service aws:sns Amazon Simple Notification Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@giograno @thrau @alexrashed @silv-io @localstack-bot
X Tutup