Swift: Add shared dataflow library #9275
Conversation
![github-code-scanning[bot]](https://web.archive.org/web/20220526183930im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| override predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet c) { | ||
| (this.isSink(node) or this.isAdditionalTaintStep(node, _)) and | ||
| defaultImplicitTaintRead(node, c) |
Check warning on line 166 in swift/ql/lib/codeql/swift/dataflow/internal/tainttracking1/TaintTrackingImpl.qll
Code scanning
QL-for-QL encountered an internal consistency error Warning
| predicate variableWrite(BasicBlock bb, int i, SourceVariable v, boolean certain) { | ||
| exists(AssignExpr assign | | ||
| bb.getNode(i).getNode() = assign and | ||
| assign.getDest() = v.getAnAccess() and |
Check warning on line 20 in swift/ql/lib/codeql/swift/dataflow/internal/SsaImplSpecific.qll
Code scanning
QL-for-QL encountered an internal consistency error Warning
| BarrierGuard() { none() } | ||
|
|
||
| /** Holds if this guard controls block `b` upon evaluating to `branch`. */ | ||
| private predicate controlsBlock(BasicBlock bb, boolean branch) { none() } |
Check warning on line 129 in swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPublic.qll
Code scanning
Dead code Warning
| predicate localFlowStepImpl(Node nodeFrom, Node nodeTo) { none() } | ||
|
|
||
| cached | ||
| newtype TContentSet = TODO_TContentSet() |
Check warning on line 46 in swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPrivate.qll
Code scanning
Dead code Warning
| /** | ||
| * The cost limits for the `AccessPathFront` to `AccessPathApprox` expansion. | ||
| * | ||
| * `apLimit` bounds the acceptable fan-out, and `tupleLimit` bounds the | ||
| * estimated per-`AccessPathFront` tuple cost. Access paths exceeding both of | ||
| * these limits are represented with lower precision during pruning. | ||
| */ |
Check warning on line 58 in swift/ql/lib/codeql/swift/dataflow/internal/DataFlowImplCommon.qll
Code scanning
Predicate QLDoc style. Warning
| /** | ||
| * The cost limits for the `AccessPathApprox` to `AccessPath` expansion. | ||
| * | ||
| * `apLimit` bounds the acceptable fan-out, and `tupleLimit` bounds the | ||
| * estimated per-`AccessPathApprox` tuple cost. Access paths exceeding both of | ||
| * these limits are represented with lower precision. | ||
| */ |
Check warning on line 70 in swift/ql/lib/codeql/swift/dataflow/internal/DataFlowImplCommon.qll
Code scanning
Predicate QLDoc style. Warning
|
The Code Scanning alerts are all either:
|
The first two commits are 100% bitwise copies from the internal repo. We can't yet add any tests since we don't extract Swift comments yet, and therefore cannot yet use the inline expectations test framework.