X Tutup
The Wayback Machine - https://web.archive.org/web/20221031122126/https://github.com/PowerShell/PowerShell/pull/17423
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the assert and use a relatively larger capacity to cover possible increase of .NET ref assemblies #17423

Merged
merged 2 commits into from May 24, 2022

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented May 24, 2022

PR Summary

Fix #17384
Update the code that gets the default reference assemblies in Add-Type to remove the assert and use a more deterministic way to get the needed capacity.

PR Checklist

@daxian-dbw daxian-dbw requested a review from PaulHigin as a code owner May 24, 2022
@daxian-dbw daxian-dbw requested a review from SteveL-MSFT May 24, 2022
@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned iSazonov May 24, 2022
@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label May 24, 2022
@msftbot msftbot bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels May 24, 2022
@pull-request-quantifier
Copy link

pull-request-quantifier bot commented May 24, 2022

This PR has 7 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -6
Percentile : 2.8%

Total files changed: 1

Change summary by file extension:
.cs : +1 -6

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw changed the title Remove the assert and use a more deterministic way to get the needed capacity Remove the assert and use a relatively larger capacity to cover possible increase of .NET ref assemblies May 24, 2022
@daxian-dbw daxian-dbw merged commit 736cf3e into PowerShell:master May 24, 2022
39 checks passed
@daxian-dbw daxian-dbw deleted the assert branch May 24, 2022
@daxian-dbw
Copy link
Member Author

daxian-dbw commented May 24, 2022

Thank you both for the review!

@msftbot
Copy link

msftbot bot commented Jun 22, 2022

🎉v7.3.0-preview.5 has been released which incorporates this pull request.🎉

Handy links:

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default reference assembly count is incorrect, causing debug assert
4 participants
X Tutup