fix(core): produce proper error message for unknown props on <ng-template>s
#46068
+98
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
action: review
comp: core
AndrewKushnir
force-pushed
the
ng-template-unknown-props
branch
from
85c576d
to
c681ba5
Compare
pkozlowski-opensource
added
the
cross-cutting: standalone
pkozlowski-opensource
approved these changes
May 20, 2022
LGTM, just left a couple of nit comments, feel free to ignore.
…plate>`s Currently for cases when an unknown structural directive is applied to `<ng-template>`s, an error message thrown by the framework doesn't contain a tag name, for example: ``` NG0303: Can't bind to 'unknownDir' since it isn't a known property of 'null'. ``` The underlying reason is that the tag name for the `<ng-template>` is not produced (`null` is useed as a value) by the compiler in case of inline templates and runtime logic relies on this effect. This commit handles this situation when an error message is thrown, as the fastest way to improve the error message. More refactoring would be needed to avoid relying on the mentioned effect at runtime.
AndrewKushnir
force-pushed
the
ng-template-unknown-props
branch
from
c681ba5
to
ca1f1e1
Compare
AndrewKushnir
added
action: presubmit
AndrewKushnir
added
action: merge
pkozlowski-opensource
approved these changes
May 23, 2022
alxhub
added
target: rc
|
This PR was merged into the repository by commit 985f8d7. |
alxhub
pushed a commit
that referenced
this issue
May 23, 2022
…plate>`s (#46068) Currently for cases when an unknown structural directive is applied to `<ng-template>`s, an error message thrown by the framework doesn't contain a tag name, for example: ``` NG0303: Can't bind to 'unknownDir' since it isn't a known property of 'null'. ``` The underlying reason is that the tag name for the `<ng-template>` is not produced (`null` is useed as a value) by the compiler in case of inline templates and runtime logic relies on this effect. This commit handles this situation when an error message is thrown, as the fastest way to improve the error message. More refactoring would be needed to avoid relying on the mentioned effect at runtime. PR Close #46068
josephperrott
pushed a commit
to josephperrott/angular
that referenced
this issue
May 24, 2022
…plate>`s (angular#46068) Currently for cases when an unknown structural directive is applied to `<ng-template>`s, an error message thrown by the framework doesn't contain a tag name, for example: ``` NG0303: Can't bind to 'unknownDir' since it isn't a known property of 'null'. ``` The underlying reason is that the tag name for the `<ng-template>` is not produced (`null` is useed as a value) by the compiler in case of inline templates and runtime logic relies on this effect. This commit handles this situation when an error message is thrown, as the fastest way to improve the error message. More refactoring would be needed to avoid relying on the mentioned effect at runtime. PR Close angular#46068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently for cases when an unknown structural directive is applied to
<ng-template>s, an error message thrown by the framework doesn't contain a tag name, for example:The underlying reason is that the tag name for the
<ng-template>is not produced (nullis used as a value) by the compiler in case of inline templates and runtime logic relies on this effect.This commit handles this situation when an error message is thrown, as the fastest way to improve the error message. More refactoring would be needed to avoid relying on the mentioned effect at runtime.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?