X Tutup
The Wayback Machine - https://web.archive.org/web/20220519145947/https://github.com/python/cpython/pull/92945
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92932: dis._unpack_opargs should handle EXTENDED_ARG_QUICK #92945

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-92932: dis._unpack_opargs should handle EXTENDED_ARG_QUICK #92945

wants to merge 2 commits into from
+4 −1

Conversation

corona10
Copy link
Member

@corona10 corona10 commented May 19, 2022 •
edited

closes: gh-92932

@corona10 corona10 requested a review from colesbury May 19, 2022
@corona10 corona10 marked this pull request as ready for review May 19, 2022
@corona10 corona10 requested a review from Fidget-Spinner May 19, 2022
@corona10 corona10 force-pushed the gh-92932 branch 2 times, most recently from 3bf6f02 to 30c7a4b Compare May 19, 2022
@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented May 19, 2022

Sorry Dong-hee, I'm useless at dis. Can't help you review this here :).

@corona10 corona10 requested a review from brandtbucher May 19, 2022
@corona10
Copy link
Member Author

@corona10 corona10 commented May 19, 2022

Sorry Dong-hee, I'm useless at dis. Can't help you review this here :).

Okay, Then I need to request this review from Brandt.

@corona10
Copy link
Member Author

@corona10 corona10 commented May 19, 2022 •
edited 

230261,230262c230261,230262
<            1118398 EXTENDED_ARG_QUICK       1
<            1118400 LOAD_GLOBAL            248 (g125)
---
>            1118398 EXTENDED_ARG_QUICK     513
>            1118400 LOAD_GLOBAL          131576 (g65789)
230265,230266c230265,230266
<            1118416 EXTENDED_ARG_QUICK       1
<            1118418 LOAD_GLOBAL            250 (g126)
---
>            1118416 EXTENDED_ARG_QUICK     513
>            1118418 LOAD_GLOBAL          131578 (g65790)
230269,230270c230269,230270
<            1118434 EXTENDED_ARG_QUICK       1
<            1118436 LOAD_GLOBAL            252 (g127)
---
>            1118434 EXTENDED_ARG_QUICK     513
>            1118436 LOAD_GLOBAL          131580 (g65791)
230273,230274c230273,230274
<            1118452 EXTENDED_ARG_QUICK       1
<            1118454 LOAD_GLOBAL            254 (g128)
---
>            1118452 EXTENDED_ARG_QUICK     513
>            1118454 LOAD_GLOBAL          131582 (g65792)
230277,230278c230277,230278
<            1118470 EXTENDED_ARG_QUICK       2
<            1118472 LOAD_GLOBAL              0 (g1)
---
>            1118470 EXTENDED_ARG_QUICK     514
>            1118472 LOAD_GLOBAL          131584 (g65793)
230281,230282c230281,230282
<            1118488 EXTENDED_ARG_QUICK       2
<            1118490 LOAD_GLOBAL              2 (g2)
---
>            1118488 EXTENDED_ARG_QUICK     514
>            1118490 LOAD_GLOBAL          131586 (g65794)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury

@Fidget-Spinner Fidget-Spinner

@brandtbucher brandtbucher

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dis._unpack_opargs should handle EXTENDED_ARG_QUICK
3 participants
@corona10 @Fidget-Spinner @bedevere-bot
X Tutup