gh-92031: Improve test for unquickening static code #92440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
May 9, 2022
| _handle_fromlist(dis, [name], lambda *args: None) | ||
| from dis import _all_opmap | ||
| resume = _all_opmap["RESUME"] | ||
| resume_quick = _all_opmap["RESUME_QUICK"] |
There was a problem hiding this comment.
Why not putting this code inside the code string?
There was a problem hiding this comment.
Since this is testing parts of importlib, I'd like to use as little import machinery as possible, so there's no chance that imports prematurely specialize the _handle_fromlist.
There was a problem hiding this comment.
Maybe add a comment to explain it, since it's not obvious the first time that I read the code: the code starts with "Assert initially unquickened".
|
Thanks @sweeneyde for the PR, and @vstinner for merging it |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2022
…pythonGH-92440) (cherry picked from commit 27185f9) Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
|
Merged, thanks! |
|
GH-92699 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This test is deterministic, faster, and directly tests the behavior it's supposed to be testing, rather than relying on some C-level assertion to fail.
I checked that commenting out
deopt_code(...)in_PyStaticCode_Dealloccauses the test to fail reliably.cc @vstinner @markshannon